From 73ad18cd7f598de5889eeae09bc5f6263b7d3e0c Mon Sep 17 00:00:00 2001 From: Xusheng Date: Thu, 14 May 2026 11:29:25 -0400 Subject: [PATCH] Fix null deref in EsrevenAdapter::GetProcessList GetProcessList dereferenced m_rspConnector unconditionally; every other method in the class already gates this access on !m_rspConnector. Mirror the same guard so the crash reported in BINARYNINJA-61 (Free user clicking Attach in the process list dialog without an active connection) returns an empty list instead of dereferencing null. Fixes #1071 Fixes BINARYNINJA-61 Co-Authored-By: Claude Opus 4.7 (1M context) --- core/adapters/esrevenadapter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/adapters/esrevenadapter.cpp b/core/adapters/esrevenadapter.cpp index c55084e8..d2a21ccf 100644 --- a/core/adapters/esrevenadapter.cpp +++ b/core/adapters/esrevenadapter.cpp @@ -2491,7 +2491,7 @@ void EsrevenAdapter::HandleAsyncPacket(const RspData& data) std::vector EsrevenAdapter::GetProcessList() { - if (m_isTargetRunning) + if (m_isTargetRunning || !m_rspConnector) return {}; // Use the custom reven list-processes packet