Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Animation crash when rendering/stopping rendering 64+ players/ragdolls #537

Closed
FoolHen opened this issue Oct 31, 2020 · 2 comments
Closed

Comments

@FoolHen
Copy link

FoolHen commented Oct 31, 2020

This crash, acording to txt, is related to

[15:25] txt: array indexing issue

[15:29] txt: crash happends in fb::ant::AnimationManager::disableAnimatable
[15:29] txt: this crash info stack trace thing is bad in some places lol
[15:30] txt: anyway the function has a max count of 64

[15:34] txt: well might be an isssue with the 64
[15:34] txt: and i don tthink its easy to extend it as well
[15:35] txt: if over 64 animated entities get disabled disabled in 1 frame then issues will arise

15:37] txt: eax = 0xd910d252
[15:37] txt: is bad
[15:38] txt: looks like it overflowed by 1
[15:38] txt: overwrote the count
[15:38] txt: then next time count is all messed up
[15:39] txt: and causes bad indexing

15:43] txt: id say if more than 64 players goes out of frame(culling) on the same frame
[15:43] txt: example is if camera teleports
[15:44] txt: one solution is to have animatables allways update
15:45] txt: fb::AntSettings.forcePoseUpdate = true

Tried setting AntSettings.forcePoseUpdate to true and AntSettings.disableModelAnimationCulling to true, and they didn't fix it.

How to repro:

BotSpawn.zip
This mod adds chat commands to spawn bots and increases the time bodies take to despawn to 300 seconds.
How to repro:

  • XP1_001 ConquestAssaultLarge0 2
  • Spawn at G, aim towards E
  • Type in chat !row 100
  • Type !kill after a second, so all bots have spawned
  • Suicide
  • Change selected flag until you crash in spawn menu.

Some rcon params that might be needed:
vu.DesertingAllowed true
vars.maxPlayers 200
vars.roundStartPlayerCount 110
vars.roundRestartPlayerCount 110

Crash dumps from latest dev 17264, running this mod and doing these steps.
dumps.zip

@OrfeasZ
Copy link
Contributor

OrfeasZ commented Nov 13, 2020

This has been fixed in build 17307. The frostbite animation code has been modified to allow up to 512 operations.

@OrfeasZ OrfeasZ closed this as completed Nov 13, 2020
@FoolHen
Copy link
Author

FoolHen commented Nov 14, 2020

Confirmed, it works now thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants