New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't log if nothing is wrong #186
Comments
Or maybe, it is because a related model has not the revisionable trait. In this case I'd consider this as a bug. |
I realize this is an old issue, but since it's still marked as open... I have exactly the same question. Is this a problem that I need to address in the code in some way? Or do I simply need to change my overall log level setting? |
It seems that it tries to call the method on a model that doesn't use the trait. |
...which probably means it's a bug :-) But unfortunately I have no idea how to fix it |
A simple |
Here : https://github.com/VentureCraft/revisionable/blob/master/src/Venturecraft/Revisionable/Revision.php#L175
This line fills the log with an "info" that is probably not useful.
I get this for each display of history :
production.INFO: Revisionable: exception 'BadMethodCallException' with message 'Call to undefined method Illuminate\Database\Query\Builder::getRevisionUnknownString()' in /[...]/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php:2071
This might fill the log quickly. Or is it the purpose of log@ info level?
The text was updated successfully, but these errors were encountered: