* Separated a GlobalOptions module

 * Removed astronomers specific rules
 * Removed types from the astronomer rules.
    * Learned: It's not always a great thing to denormalize data, it leads to inconsistency opportunities. An instance of premature optimization likely. Now I'm questioning why .ll does this.
 * Added better humanizing of errors
 * Added a MUCH better solver error printer
 * Brought back the distinction between declaration names and imprecise names
 * Made a better distinction between drop and free
 * Fixed build failure counting bug in Tester
 * Took out localRunes and knowableRunes from Astronomer, moved some of that logic back into astronomer.
    * Learned: It's not always a great thing to pull as much logic as possible out of Templar. In this case, reducing the amount of code in Templar actually increased its complexity, ironically.
 * Changed some astronomer tests into integration tests, feeding actual vale source code now.
    * Learned: Unit tests have a high cost in maintaining the inputs. Perhaps unit tests only make sense on very established chunks of code.
 * Moved a bunch of hardcoded functions (weaks, drop, free, array len, panic) to actual vale code.
 * Made tuple an extern struct, using variadic members.
 * We now internally support variadic members!
 * Made a functor struct, to give to the array instructions, since they need a 'this' object basically
 * Removed special PackTT type.
 * Took out `all` function, pulled into a separate Collector class
 * Added the "macro" concept, for any syntactical sugar features (or semantic sugar? like anonymous substructs, theyre kind of semantic sugar I guess?)
 * Moved drop functions into macros.
 * Moved anonymous substruct functionality into macros.
 * Better distinction between a template name and a stamped name, see CitizenNameT vs CitizenTemplateNameT.
 * Fixed types starting with _, like __Never
 * Added free() functions for interfaces, which then call virtualfree(). Now, there is a normal free() function for every immutable type.
 * Fixed printing exceptions twice in tests
 * Added a "Location In Function" notion, so places in the code are marked by tree-shaped paths
 * Made impl rules sane again, no more NMORFI!

Breaking changes:
- Void's name changed from Tup0_0 to Tup0
- To define abstract functions outside an interface, now need `sealed` on the interface
- To make custom destructors, need #!DeriveStructDrop now, and it's called `drop` not `destructor`.
- All parameters need a type. `fn do(callable)` -> `fn do<F>(callable F)`

Author: Verdagon

Midas/src/c-compiler/globalstate.h

@@ -181,6 +181,7 @@ class GlobalState {
         return numMetalMethods + i;
       }
     }
+    std::cerr << "Couldn't find method " << prototype->name->name << " in interface " << interfaceKindM->fullName->name << std::endl;
     assert(false);
   }
 

Midas/src/c-compiler/metal/readjson.cpp

@@ -587,7 +587,7 @@ StructDefinition* readStruct(MetalCache* cache, const json& struuct) {
           struuct["weakable"] ? Weakability::WEAKABLE : Weakability::NON_WEAKABLE);
 
   auto structName = result->name;
-  if (structName->name == std::string("Tup0_0")) {
+  if (structName->name == std::string("Tup_0")) {
     cache->emptyTupleStruct = cache->getStructKind(structName);
     cache->emptyTupleStructRef =
         cache->getReference(Ownership::SHARE, Location::INLINE, cache->emptyTupleStruct);

Midas/src/c-compiler/region/rcimm/rcimm.cpp

@@ -702,34 +702,8 @@ void RCImm::discard(
           buildFlare(from, globalState, functionState, thenBuilder, "Freeing shared str!");
           innerDeallocate(from, globalState, functionState, &kindStructs, thenBuilder, sourceMT, sourceRef);
         });
-  } else if (auto interfaceRnd = dynamic_cast<InterfaceKind *>(sourceRnd)) {
-    buildFlare(FL(), globalState, functionState, builder);
-    assert(sourceMT->ownership == Ownership::SHARE);
-    if (sourceMT->location == Location::INLINE) {
-      assert(false); // impl
-    } else {
-      auto rcLE =
-          adjustStrongRc(
-              from, globalState, functionState, &kindStructs, builder, sourceRef, sourceMT, -1);
-      buildIf(
-          globalState, functionState,
-          builder,
-          isZeroLE(builder, rcLE),
-          [globalState, functionState, sourceRef, interfaceRnd, sourceMT](
-              LLVMBuilderRef thenBuilder) {
-            auto immDestructor = globalState->program->getImmDestructor(sourceMT->kind);
-
-//            auto virtualArgRefMT = functionType->params[virtualParamIndex];
-//            auto virtualArgRef = argsLE[virtualParamIndex];
-            int indexInEdge = globalState->getInterfaceMethodIndex(interfaceRnd, immDestructor);
-            auto methodFunctionPtrLE =
-                globalState->getRegion(sourceMT)
-                    ->getInterfaceMethodFunctionPtr(functionState, thenBuilder, sourceMT, sourceRef, indexInEdge);
-            buildInterfaceCall(
-                globalState, functionState, thenBuilder, immDestructor, methodFunctionPtrLE, {sourceRef}, 0);
-          });
-    }
-  } else if (dynamic_cast<StructKind *>(sourceRnd) ||
+  } else if (dynamic_cast<InterfaceKind *>(sourceRnd) ||
+      dynamic_cast<StructKind *>(sourceRnd) ||
       dynamic_cast<StaticSizedArrayT *>(sourceRnd) ||
       dynamic_cast<RuntimeSizedArrayT *>(sourceRnd)) {
     buildFlare(FL(), globalState, functionState, builder);

Tester/src/main.vale

@@ -349,6 +349,7 @@ fn FinishTests(suite &!TestSuite, until_this_many_left int) {
         println("stderr:");
         println(build_result.stderr);
       }
+      set suite.num_failures = suite.num_failures + 1;
     } else {
       program_name = if (IsWindows()) { "main.exe" } else { "main" };
       run_program = test_build_dir./(program_name).str();

Valestrom/.idea/codeStyles/Project.xml

@@ -15,5 +15,7 @@
     <orderEntry type="module" module-name="Utils" />
     <orderEntry type="library" name="org.scalatest:scalatest_2.12:3.0.8" level="project" />
     <orderEntry type="library" name="scala-sdk-2.12.6" level="application" />
+    <orderEntry type="module" module-name="Solver" />
+    <orderEntry type="module" module-name="Options" />
   </component>
 </module>