Performant way to using StateReader #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muukii
changed the title
muukii
changed the title
muukii
commented
Oct 7, 2020
|
|
||
| /** Not working */ | ||
| @available(iOS 13, *) | ||
| final class StateReaderTests: XCTestCase { |
There was a problem hiding this comment.
I tried.
but I could not run SwiftUI's view on XCTest.
muukii
commented
Oct 7, 2020
| @@ -0,0 +1,94 @@ | |||
| // | |||
| // ContentView.swift | |||
There was a problem hiding this comment.
A demo application to check the behavior of StateReader
muukii
force-pushed
the
muukii/performant-state-reader
branch
from
8e1d223
to
b9cc1ef
Compare
muukii
commented
Oct 7, 2020
| */ | ||
| @available(iOS 13, macOS 10.15, tvOS 13, watchOS 6, *) | ||
| public struct StateReader<Value, Content: View>: View { | ||
| public struct StateReader<Value>: View { |
There was a problem hiding this comment.
StateReader is going to be new API
muukii
commented
Oct 7, 2020
Comment on lines
+53
to
+61
| public var body: EmptyView { | ||
| assertionFailure(""" | ||
| Warning: StateReader still does not have a content-view. | ||
| Please add a content by `.content()`. | ||
|
|
||
| This issue comes from current auto-completion function doesn't work well. | ||
| Probably, it's might be fixed with better syntax. | ||
| """) | ||
| return EmptyView() |
There was a problem hiding this comment.
here is not cool part
muukii
commented
Oct 7, 2020
Comment on lines
+69
to
+71
| public func content<NewContent: View>(_ makeContent: @escaping (Changes<Value>) -> NewContent) -> _StateReaderContent<Value, NewContent> { | ||
| return .init(updateTrigger: observableObject, updateValue: updateValue, content: makeContent) | ||
| } |
There was a problem hiding this comment.
We need to call this to describe content view
muukii
commented
Oct 7, 2020
| /// - content: | ||
| public init<Derived: DerivedType>( | ||
| _ derived: Derived, | ||
| _ map: MemoizeMap<Changes<Derived.Value>, Value>, |
There was a problem hiding this comment.
Passing MemoizeMap causes the complexity of auto-completion and verbosity of signature.
In most of the cases, it's enough passing Derived object.
If we need to create chained Derived, pass the chained Derived from outside.
muukii
force-pushed
the
muukii/performant-state-reader
branch
from
6896002
to
716ffcf
Compare
muukii
force-pushed
the
muukii/performant-state-reader
branch
from
716ffcf
to
1f7da19
Compare
muukii
commented
Oct 8, 2020
| } | ||
|
|
||
| @available(*, deprecated, message: "You're returning a value which is not a type of `SwiftUI.View`.") | ||
| public func content(_ makeContent: @escaping (Changes<Value>) -> Never) -> Never { |
There was a problem hiding this comment.
This method is dummy just for Xcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better performance, to reduce creating view structure in body property as possible.
We suggest you use Derived object as possible instead of directly passing a Store into StateReader.
The derived object can focus on properties that you need inside StateReader, and emit events of request view update only their changed.
In using the store directly, StateReader also updates itself from the events of unused properties changed.
To solve:
#160
And It contains also writing issues in Xcode.
#165
Before
After