Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Support ADFS5 Form Format #343

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@nathandines
Copy link
Contributor

commented Sep 18, 2019

Fixes #283

ADFS 5.0 on Windows Server 2019 introduces a hidden field with the name
of "UserName" and the id of "userNameInputOptionsHolder". saml2aws will
include this in the fields which it populates when submitting a request
to ADFS.

ADFS encounters an error when both "UserName" fields are populated, so
this change ensures that only "user" and "password" fields which are
visible to the user will be populated by saml2aws and submitted to ADFS.

Fixes #283

ADFS 5.0 on Windows Server 2019 introduces a hidden field with the name
of "UserName" and the id of "userNameInputOptionsHolder". saml2aws will
include this in the fields which it populates when submitting a request
to ADFS.

ADFS encounters an error when both "UserName" fields are populated, so
this change ensures that only "user" and "password" fields which are
visible to the user will be populated by saml2aws and submitted to ADFS.
@nathandines

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

Actually, going to pause on this. Might need a little more work Never mind, PEBCAK with one of the people testing it. Re-opening the PR

@nathandines nathandines reopened this Sep 18, 2019
@nathandines

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Hey @wolfeidau, any chance we could please get this into a release soon?

I'm hoping to avoid distributing a custom build at one of my clients and keep them using the proper installation channels.

@wolfeidau wolfeidau merged commit 5bd039d into Versent:master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.