Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Filter summaries clientside in get_or_create #2200

Merged
merged 1 commit into from Apr 21, 2021

Conversation

daniel-verta
Copy link
Contributor

An issue on the backend requires that we apply some client-side filtering of retrieved summaries in get_or_create.

Testing

(verta-py3) daniel@Daniels-MacBook-Pro notebooks % ipython
Python 3.7.9 (default, Feb 17 2021, 15:51:40)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.21.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from verta import Client
   ...: from verta import data_types
   ...: client = Client()
   ...: ops = client.operations
   ...: monitored = ops.get_or_create_monitored_entity("Prophet Demo 1126")
   ...: mse_summary = ops.summaries.get_or_create("mse", data_types.NumericValue, monitored)
   ...:
set host from environment
set email from environment
set developer key from environment
connection successfully established
got existing MonitoredEntity: Prophet Demo 1126

In [2]: new_summary = ops.summaries.get_or_create("new summary", data_types.FloatHistogram, monitored)

In [3]: new_summary
Out[3]: Summary name:new summary, type:verta.floatHistogram.v1, monitored_entity_id:2

In [4]: mse_summary
Out[4]: Summary name:mse, type:verta.numericValue.v1, monitored_entity_id:2

@daniel-verta daniel-verta merged commit 4bae6f3 into master Apr 21, 2021
@daniel-verta daniel-verta deleted the df/getSummary-patch branch April 21, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants