Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CAT-155] - Log dataset into RMV using Client #3335

Merged
merged 14 commits into from Nov 7, 2022
Merged

Conversation

marcelo-verta-ai
Copy link
Contributor

@marcelo-verta-ai marcelo-verta-ai commented Nov 3, 2022

Summary

Log dataset into RMV using Client

References

https://vertaai.atlassian.net/browse/CAT-155?atlOrigin=eyJpIjoiNmU5YjM3YTg2N2M1NDUxMmIyMGU1NWE2OWNkMDUwYTUiLCJwIjoiaiJ9

Test Result (2022-11-07 10:00 GMT -3)

export VERTA_HOST="https://modelcatalog.dev.verta.ai/"
export VERTA_EMAIL="marcelo@verta.ai"
export VERTA_DEV_KEY="7ae98d72-d0dd-4034-9fb1-e2f79e894fd9"
python3.9 -m pytest -k "TestLogDataset" -rfE
============================================================================= test session starts ==============================================================================
platform linux -- Python 3.9.15, pytest-7.2.0, pluggy-1.0.0
rootdir: /opt/repositorio-git/verta/modeldb/client/verta/tests, configfile: pytest.ini
plugins: xdist-3.0.2, hypothesis-6.56.4
collected 1258 items / 1257 deselected / 3 skipped / 1 selected                                                                                                                

registry/model_version/test_log_dataset.py .                                                                                                                             [100%]

=============================================================================== warnings summary ===============================================================================
test_utils/test_pip_requirements.py:170
  /opt/repositorio-git/verta/modeldb/client/verta/tests/test_utils/test_pip_requirements.py:170: NonInteractiveExampleWarning: The `.example()` method is good for exploring strategies, but should only be used interactively.  We recommend using `@given` for tests - it performs better, saves and replays failures to avoid flakiness, and reports minimal examples. (strategy: versions())
    version=versions().example(),  # pylint: disable=no-member

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================== 1 passed, 3 skipped, 1257 deselected, 1 warning in 28.00s ===========================================================


Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend following my API recommendations in the Jira ticket description (I was worried they would be easy to miss 😞) to match the API for ExperimentRun.

But this looks good as a first step! I know it was a lot of hard work between you and Matheus to test this

client/verta/verta/registry/entities/_modelversion.py Outdated Show resolved Hide resolved
client/verta/verta/registry/entities/_modelversion.py Outdated Show resolved Hide resolved
client/verta/verta/registry/entities/_modelversion.py Outdated Show resolved Hide resolved
@liuverta liuverta changed the title feat: [CAT-155] - Log dataset into RMV using CLI feat: [CAT-155] - Log dataset into RMV using Client Nov 4, 2022
Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments.

marcelo-verta-ai and others added 6 commits November 4, 2022 15:55
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
feat: implemented del_dataset_version
Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small changes, but this looks good overall.

marcelo-verta-ai and others added 3 commits November 7, 2022 09:55
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@liuverta liuverta merged commit 82e3d18 into main Nov 7, 2022
@liuverta liuverta deleted the marcelo/cat-155 branch November 7, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants