New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CAT-155] - Log dataset into RMV using Client #3335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend following my API recommendations in the Jira ticket description (I was worried they would be easy to miss 😞) to match the API for ExperimentRun
.
But this looks good as a first step! I know it was a lot of hard work between you and Matheus to test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more comments.
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
feat: implemented del_dataset_version
feat: implemented del_dataset_version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes, but this looks good overall.
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Summary
Log dataset into RMV using Client
References
https://vertaai.atlassian.net/browse/CAT-155?atlOrigin=eyJpIjoiNmU5YjM3YTg2N2M1NDUxMmIyMGU1NWE2OWNkMDUwYTUiLCJwIjoiaiJ9
Test Result (2022-11-07 10:00 GMT -3)