Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set samtools wrapper to use mpileup instead of pileup. #35

Closed

Conversation

CraigPorter
Copy link
Contributor

I've set the samtools wrapper to run mpileup instead of pileup.

Pileup has been removed from samtools so anything trying to use the wrapper to run samtools pileup on a recent version of samtools will fail.

So saying, I suspect the only thing using the wrapper to run pileup is the genome coverage option in the mapping pipeline. And I'm planning to fix the genome coverage option next week.

@CraigPorter
Copy link
Contributor Author

Added an error check to the genome coverage function.

I considered changing the script file in the mapping pipeline that calls the genome coverage function to run samtools but thought it best to use the sam module.

If you want me to add mpileup to the samtools wrapper then I'm happy to do that otherwise I'm happy with the current fix.

@CraigPorter
Copy link
Contributor Author

Identical (cherry-picked) commits just merged into develop. Closing pull request.

andrewjpage referenced this pull request in andrewjpage/vr-codebase Nov 22, 2011
Fix to fastq import - delete bams after fastq gzipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant