Skip to content

fix: filter out error messages from killing the server process #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 11, 2023
Merged

fix: filter out error messages from killing the server process #592

merged 7 commits into from
Apr 11, 2023

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Mar 30, 2023 •
edited
Loading

Description

Proposal for fix: #460 (comment)

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo mentioned this pull request Mar 30, 2023
Closed
@renancaraujo renancaraujo marked this pull request as ready for review March 30, 2023 20:31
@renancaraujo renancaraujo force-pushed the renan/hot-reload-problem branch from 5b6fa0a to 832ed57 Compare March 30, 2023 20:37
@renancaraujo renancaraujo force-pushed the renan/hot-reload-problem branch from 039e3fe to 901c52a Compare March 30, 2023 20:50
@renancaraujo renancaraujo force-pushed the renan/hot-reload-problem branch from 901c52a to e09e767 Compare March 30, 2023 20:52
@wolfenrain wolfenrain changed the title fix: filter out error messages form killing the server process fix: filter out error messages from killing the server process Apr 11, 2023
@wolfenrain wolfenrain merged commit 281bbd0 into main Apr 11, 2023
@wolfenrain wolfenrain deleted the renan/hot-reload-problem branch April 11, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@alestiago alestiago alestiago approved these changes

@felangel felangel Awaiting requested review from felangel

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: process is killed on linter warning
3 participants
@renancaraujo @wolfenrain @alestiago