Skip to content

fix(dart_frog): Response.json() overwrites content-type header #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 18, 2023
Merged

fix(dart_frog): Response.json() overwrites content-type header #596

merged 6 commits into from
Apr 18, 2023

Conversation

easazade
Copy link
Contributor

@easazade easazade commented Apr 7, 2023 •
edited by wolfenrain
Loading

Status

READY

Description

Fixes the bug that didn't allow overriding content-type headers when using Response.json() constructor

Closes #593

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wolfenrain
Copy link
Member

I just saw this, I opened #604 but I am fine with closing mine in favour of this, I would prefer if we use the if statement approach that I did as it is more explicit in what we are doing there.

@wolfenrain wolfenrain changed the title fix(dart_frog): Response.json() overwrites content-type header #593 fix(dart_frog): Response.json() overwrites content-type header Apr 12, 2023
@easazade
Copy link
Contributor Author

I just saw this, I opened #604 but I am fine with closing mine in favour of this, I would prefer if we use the if statement approach that I did as it is more explicit in what we are doing there.

That is very kind of you, I made the changes you asked.

@easazade
Copy link
Contributor Author

@wolfenrain Feel free to merge yours if you want to

@wolfenrain wolfenrain mentioned this pull request Apr 12, 2023
Closed
7 tasks
@wolfenrain wolfenrain merged commit 76c3d9d into VeryGoodOpenSource:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@alestiago alestiago alestiago approved these changes

@felangel felangel Awaiting requested review from felangel

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Response.json() overwrites content-type header
4 participants
@easazade @wolfenrain @renancaraujo @alestiago