fix(dart_frog): Pipeline
does not maintain RequestContext
#605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Currently, when using Dart Frog in a situation where middleware is applied, the
RequestContext
which theHandler
is called with is not the sameRequestContext
which theMiddleware
is called with. This is problematic especially in tests because it is not possible to mock dependencies which are accessed viacontext.read
from within middleware.See the following example:
In the above example, the
RequestContext
in the middleware is not the same as theRequestContext
in the handlers because dart frog creates a newRequestContext
internally. This makes it impossible to mockcontext.read<Database>()
in the above example.Type of Change