feat: support custom org name #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Jul 12, 2021
Co-authored-by: Felix Angelov <felangelov@gmail.com>
felangel
reviewed
Jul 12, 2021
lib/src/commands/create.dart
Outdated
| /// Gets the organization name. | ||
| List<Map<String, String>> get _orgName { | ||
| final orgName = | ||
| (_argResults['org-name'] ?? 'com.example.verygoodcore') as String; |
There was a problem hiding this comment.
can we create a constant _defaultOrgName = 'com.example.verygoodcore';?
felangel
reviewed
Jul 12, 2021
lib/src/commands/create.dart
Outdated
| List<Map<String, String>> get _orgName { | ||
| final orgName = | ||
| (_argResults['org-name'] ?? 'com.example.verygoodcore') as String; | ||
| _validateOrgName(orgName); |
There was a problem hiding this comment.
don't we only need to validate if it's not the default? I think we can return the default early if the user didn't provide a custom org-name.
felangel
reviewed
Jul 12, 2021
felangel
reviewed
Jul 12, 2021
|
@denangelov looks like the build is failing. Let me know if you need help fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified CLI to support additional argument for a custom organization name.
Type of Change