ci: add the check-ignore flag in dart coverage #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmartins
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
wolfenrain
reviewed
Mar 11, 2023
.github/workflows/dart_package.yml
Outdated
| @@ -77,7 +77,7 @@ jobs: | |||
| - name: 🧪 Run Tests | |||
| run: | | |||
| dart pub global activate coverage 1.2.0 | |||
| dart test -j ${{inputs.concurrency}} --coverage=coverage --platform=${{inputs.platform}} && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=${{inputs.report_on}} | |||
| dart test -j ${{inputs.concurrency}} --coverage=coverage --platform=${{inputs.platform}} && dart pub global run coverage:format_coverage --lcov --check-ignore --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=${{inputs.report_on}} | |||
There was a problem hiding this comment.
We should add this under an option as this could be considered breaking for anyone using this in the next version
There was a problem hiding this comment.
OK, I added a new input for this.
There was a problem hiding this comment.
@wolfenrain I think we should go forward with the breaking change.
I think it is more sensible to have it enabled by default. Since if you are using comments to ignore particular sections of the code you're most likely doing it purposely already.
|
This might be related to VeryGoodOpenSource/very_good_coverage#200. |
This was referenced Mar 16, 2023
renancaraujo
previously approved these changes
Mar 16, 2023
alestiago
requested changes
Mar 17, 2023
kmartins
force-pushed
the
ci/new_flag_coverage
branch
from
06c62b8
to
0e51426
Compare
kmartins
force-pushed
the
ci/new_flag_coverage
branch
from
0e51426
to
ca1cd36
Compare
renancaraujo
previously approved these changes
Mar 21, 2023
alestiago
reviewed
Mar 28, 2023
alestiago
previously approved these changes
Mar 28, 2023
wolfenrain
previously approved these changes
Mar 29, 2023
kmartins
dismissed stale reviews from wolfenrain, alestiago, and renancaraujo
via
f9eec16
alestiago
previously approved these changes
Apr 5, 2023
renancaraujo
previously approved these changes
Apr 18, 2023
wolfenrain
reviewed
Apr 20, 2023
wolfenrain
reviewed
Apr 20, 2023
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
renancaraujo
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the flag
--check-ignorein Dart Coverage for comments below to work:Type of Change