Part 1: Fixing v1 release to not include breaking changes. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-GV
force-pushed
the
release-1.X-rollback
branch
from
1866d45
to
3e2734c
Compare
Red-GV
force-pushed
the
release-1.X-rollback
branch
from
90f9db8
to
b36d5d8
Compare
xperimental
approved these changes
Apr 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a three merge chain to fix the release versioning of the
logerrlibrary. This PR (#20) incorrectly versioned breaking changes as a minor release instead of a major one. Thus this PR minimally upgrades thelogerrlibrary to go1.17. In addition, it updates thelogrlibrary tov0.4.0.Once this PR is merged and tagged, the v1.1.0 and v1.1.1 will be retracted. A followup PR will be released to revert this one as to not lose the work for #20 or #21. Finally, more addendums will be provided to the
MIGRATION.mddocument to help developers better adopt the changes to thelogerrlibrary as a result of #20 and #21. This version will then be released asv2.0.0.