Replace printStackTrace usages with proper logging (#3741)

FlorianMichael · web-flow · commit 7b0c2fb51a9f · 2024-03-09T13:57:41.000+01:00
diff --git a/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_9to1_8/ArmorListener.java b/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_9to1_8/ArmorListener.java
@@ -25,6 +25,7 @@
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.ClientboundPackets1_9;
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.Protocol1_9To1_8;
 import java.util.UUID;
+import java.util.logging.Level;
 import org.bukkit.Bukkit;
 import org.bukkit.entity.HumanEntity;
 import org.bukkit.entity.Player;
@@ -71,7 +72,7 @@ public void sendArmorUpdate(Player player) {
 
             wrapper.scheduleSend(Protocol1_9To1_8.class);
         } catch (Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send armor update", e);
         }
     }
 
diff --git a/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_9to1_8/DeathListener.java b/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_9to1_8/DeathListener.java
@@ -30,6 +30,7 @@
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.entity.PlayerDeathEvent;
 import org.bukkit.plugin.Plugin;
+import java.util.logging.Level;
 
 public class DeathListener extends ViaBukkitListener {
 
@@ -66,7 +67,7 @@ private void sendPacket(final Player p, final String msg) {
 
                     wrapper.scheduleSend(Protocol1_9To1_8.class);
                 } catch (Exception e) {
-                    e.printStackTrace();
+                    Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send death message", e);
                 }
             }
         });
diff --git a/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/util/ProtocolSupportUtil.java b/bukkit-legacy/src/main/java/com/viaversion/viaversion/bukkit/util/ProtocolSupportUtil.java
@@ -19,6 +19,8 @@
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.logging.Level;
+import com.viaversion.viaversion.api.Via;
 import org.bukkit.entity.Player;
 
 public final class ProtocolSupportUtil {
@@ -46,7 +48,7 @@ public static int getProtocolVersion(Player player) {
             Object version = PROTOCOL_VERSION_METHOD.invoke(null, player);
             return (int) GET_ID_METHOD.invoke(version);
         } catch (IllegalAccessException | InvocationTargetException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to get ProtocolSupport version", e);
         }
         return -1;
     }
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/multiversion/PlayerSneakListener.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/multiversion/PlayerSneakListener.java
@@ -30,6 +30,7 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.WeakHashMap;
+import java.util.logging.Level;
 import org.bukkit.entity.EntityType;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
@@ -148,7 +149,7 @@ private void setHeight(Player player, float height) {
         try {
             setSize.invoke(getHandle.invoke(player), DEFAULT_WIDTH, height);
         } catch (IllegalAccessException | InvocationTargetException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to set player height", e);
         }
     }
 }
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_15to1_14_4/EntityToggleGlideListener.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/protocol1_15to1_14_4/EntityToggleGlideListener.java
@@ -18,6 +18,7 @@
 package com.viaversion.viaversion.bukkit.listeners.protocol1_15to1_14_4;
 
 import com.viaversion.viaversion.ViaVersionPlugin;
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.api.minecraft.metadata.Metadata;
 import com.viaversion.viaversion.api.protocol.packet.PacketWrapper;
 import com.viaversion.viaversion.api.type.Type;
@@ -26,6 +27,7 @@
 import com.viaversion.viaversion.protocols.protocol1_15to1_14_4.ClientboundPackets1_15;
 import com.viaversion.viaversion.protocols.protocol1_15to1_14_4.Protocol1_15To1_14_4;
 import java.util.Arrays;
+import java.util.logging.Level;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
@@ -84,7 +86,7 @@ public void entityToggleGlide(EntityToggleGlideEvent event) {
                 packet.write(Types1_14.METADATA_LIST, Arrays.asList(new Metadata(0, Types1_14.META_TYPES.byteType, bitmask)));
                 packet.scheduleSend(Protocol1_15To1_14_4.class);
             } catch (Exception e) {
-                e.printStackTrace();
+                Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send entity glide fix metadata", e);
             }
         }
     }
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/platform/BukkitViaInjector.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/platform/BukkitViaInjector.java
@@ -18,6 +18,7 @@
 package com.viaversion.viaversion.bukkit.platform;
 
 import com.google.common.base.Preconditions;
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.bukkit.handlers.BukkitChannelInitializer;
 import com.viaversion.viaversion.bukkit.util.NMSUtil;
 import com.viaversion.viaversion.platform.LegacyViaInjector;
@@ -30,6 +31,7 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.util.List;
+import java.util.logging.Level;
 import org.bukkit.Bukkit;
 import org.bukkit.plugin.PluginDescriptionFile;
 import org.checkerframework.checker.nullness.qual.Nullable;
@@ -217,7 +219,7 @@ public boolean isBinded() {
                 }
             }
         } catch (ReflectiveOperationException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to check if ViaVersion is binded", e);
         }
         return false;
     }
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitInventoryQuickMoveProvider.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitInventoryQuickMoveProvider.java
@@ -153,7 +153,7 @@ public boolean sendPacketToServer(Player p, Object packet) {
             // send
             packetMethod.invoke(playerConnection, packet);
         } catch (IllegalAccessException | InvocationTargetException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to send packet to server", e);
             return false;
         }
         return true;
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitViaMovementTransmitter.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitViaMovementTransmitter.java
@@ -25,6 +25,7 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.logging.Level;
 
 import com.viaversion.viaversion.util.PipelineUtil;
 import io.netty.channel.ChannelHandlerContext;
@@ -109,7 +110,7 @@ public void sendPlayer(UserConnection info) {
                         info.get(MovementTracker.class).incrementIdlePacket();
                     }
                 } catch (IllegalAccessException | InvocationTargetException e) {
-                    e.printStackTrace();
+                    Via.getPlatform().getLogger().log(Level.WARNING, "Failed to handle idle packet", e);
                 }
             }
         } else {
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/tasks/protocol1_19to1_18_2/AckSequenceTask.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/tasks/protocol1_19to1_18_2/AckSequenceTask.java
@@ -17,12 +17,14 @@
  */
 package com.viaversion.viaversion.bukkit.tasks.protocol1_19to1_18_2;
 
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.api.connection.UserConnection;
 import com.viaversion.viaversion.api.protocol.packet.PacketWrapper;
 import com.viaversion.viaversion.api.type.Type;
 import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.ClientboundPackets1_19;
 import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.Protocol1_19To1_18_2;
 import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.storage.SequenceStorage;
+import java.util.logging.Level;
 
 public final class AckSequenceTask implements Runnable {
 
@@ -42,7 +44,7 @@ public void run() {
             ackPacket.write(Type.VAR_INT, sequence);
             ackPacket.scheduleSend(Protocol1_19To1_18_2.class);
         } catch (final Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send block changed ack packet", e);
         }
     }
 }
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/handlers/BungeeChannelInitializer.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/handlers/BungeeChannelInitializer.java
@@ -17,12 +17,14 @@
  */
 package com.viaversion.viaversion.bungee.handlers;
 
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.api.connection.UserConnection;
 import com.viaversion.viaversion.connection.UserConnectionImpl;
 import com.viaversion.viaversion.protocol.ProtocolPipelineImpl;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelInitializer;
 import java.lang.reflect.Method;
+import java.util.logging.Level;
 
 public class BungeeChannelInitializer extends ChannelInitializer<Channel> {
     private final ChannelInitializer<Channel> original;
@@ -34,7 +36,7 @@ public BungeeChannelInitializer(ChannelInitializer<Channel> oldInit) {
             this.method = ChannelInitializer.class.getDeclaredMethod("initChannel", Channel.class);
             this.method.setAccessible(true);
         } catch (NoSuchMethodException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to get initChannel method", e);
         }
     }
 
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/handlers/BungeeServerHandler.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/handlers/BungeeServerHandler.java
@@ -44,6 +44,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.UUID;
+import java.util.logging.Level;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.api.connection.Server;
 import net.md_5.bungee.api.event.ServerConnectEvent;
@@ -108,7 +109,7 @@ public void onServerConnect(ServerConnectEvent event) {
             Object handshake = getHandshake.invoke(event.getPlayer().getPendingConnection());
             setProtocol.invoke(handshake, protocols == null ? clientProtocolVersion : serverProtocolVersion);
         } catch (InvocationTargetException | IllegalAccessException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Error setting handshake version", e);
         }
     }
 
@@ -117,7 +118,7 @@ public void onServerConnected(ServerConnectedEvent event) {
         try {
             checkServerChange(event, Via.getManager().getConnectionManager().getConnectedClient(event.getPlayer().getUniqueId()));
         } catch (Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to handle server switch", e);
         }
     }
 
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/listeners/ElytraPatch.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/listeners/ElytraPatch.java
@@ -28,6 +28,7 @@
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.Protocol1_9To1_8;
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.storage.EntityTracker1_9;
 import java.util.Collections;
+import java.util.logging.Level;
 import net.md_5.bungee.api.event.ServerConnectedEvent;
 import net.md_5.bungee.api.plugin.Listener;
 import net.md_5.bungee.event.EventHandler;
@@ -56,7 +57,7 @@ public void onServerConnected(ServerConnectedEvent event) {
                 wrapper.scheduleSend(Protocol1_9To1_8.class);
             }
         } catch (Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send elytra patch metadata packet!", e);
         }
     }
 }
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/providers/BungeeMainHandProvider.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/providers/BungeeMainHandProvider.java
@@ -17,11 +17,13 @@
  */
 package com.viaversion.viaversion.bungee.providers;
 
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.api.connection.ProtocolInfo;
 import com.viaversion.viaversion.api.connection.UserConnection;
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.providers.MainHandProvider;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.logging.Level;
 import net.md_5.bungee.api.ProxyServer;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 
@@ -52,7 +54,7 @@ public void setMainHand(UserConnection user, int hand) {
                 setMainHand.invoke(settings, hand);
             }
         } catch (IllegalAccessException | InvocationTargetException e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to set main hand for " + player.getName(), e);
         }
     }
 }
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/providers/BungeeVersionProvider.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/providers/BungeeVersionProvider.java
@@ -68,10 +68,9 @@ public static int getLowestSupportedVersion() {
         try {
             list = ReflectionUtil.getStatic(ProtocolConstants.class, "SUPPORTED_VERSION_IDS", List.class);
             return list.get(0);
-        } catch (NoSuchFieldException | IllegalAccessException e) {
-            e.printStackTrace();
+        } catch (NoSuchFieldException | IllegalAccessException ignored) {
+            // Fallback
+            return ProxyServer.getInstance().getProtocolVersion();
         }
-        // Fallback
-        return ProxyServer.getInstance().getProtocolVersion();
     }
 }
diff --git a/bungee/src/main/java/com/viaversion/viaversion/bungee/storage/BungeeStorage.java b/bungee/src/main/java/com/viaversion/viaversion/bungee/storage/BungeeStorage.java
@@ -17,11 +17,13 @@
  */
 package com.viaversion.viaversion.bungee.storage;
 
+import com.viaversion.viaversion.api.Via;
 import com.viaversion.viaversion.api.connection.StorableObject;
 import java.lang.reflect.Field;
 import java.util.Objects;
 import java.util.Set;
 import java.util.UUID;
+import java.util.logging.Level;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 
 public class BungeeStorage implements StorableObject {
@@ -52,7 +54,7 @@ public BungeeStorage(ProxiedPlayer player) {
             try {
                 bossbar = (Set<UUID>) bossField.get(player);
             } catch (IllegalAccessException e) {
-                e.printStackTrace();
+                Via.getPlatform().getLogger().log(Level.WARNING, "Failed to get bossbar list", e);
             }
         }
     }
diff --git a/common/src/main/java/com/viaversion/viaversion/legacy/bossbar/CommonBoss.java b/common/src/main/java/com/viaversion/viaversion/legacy/bossbar/CommonBoss.java
@@ -36,6 +36,7 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
+import java.util.logging.Level;
 
 public class CommonBoss implements BossBar {
     private final UUID uuid;
@@ -233,7 +234,7 @@ private void sendPacketConnection(UserConnection conn, PacketWrapper wrapper) {
         try {
             wrapper.scheduleSend(Protocol1_9To1_8.class);
         } catch (Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send bossbar packet", e);
         }
     }
 
@@ -269,7 +270,7 @@ private PacketWrapper getPacket(UpdateAction action, UserConnection connection)
 
             return wrapper;
         } catch (Exception e) {
-            e.printStackTrace();
+            Via.getPlatform().getLogger().log(Level.WARNING, "Failed to create bossbar packet", e);
         }
         return null;
     }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol1_7.java b/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol1_7.java
@@ -110,7 +110,7 @@ public void register() {
 
                         wrapper.set(Type.STRING, 0, GsonUtil.getGson().toJson(json)); // Update value
                     } catch (JsonParseException e) {
-                        e.printStackTrace();
+                        Via.getPlatform().getLogger().log(Level.SEVERE, "Error handling StatusResponse", e);
                     }
                 });
             }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_11to1_10/metadata/MetadataRewriter1_11To1_10.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_11to1_10/metadata/MetadataRewriter1_11To1_10.java
@@ -125,7 +125,7 @@ protected void registerRewrites() {
 
                         wrapper.send(Protocol1_11To1_10.class);
                     } catch (Exception e) {
-                        e.printStackTrace();
+                        Via.getPlatform().getLogger().log(Level.WARNING, "Failed to update hologram position", e);
                     }
                 }
             }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_12to1_11_1/Protocol1_12To1_11_1.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_12to1_11_1/Protocol1_12To1_11_1.java
@@ -48,6 +48,7 @@
 import com.viaversion.viaversion.protocols.protocol1_9_3to1_9_1_2.ServerboundPackets1_9_3;
 import com.viaversion.viaversion.protocols.protocol1_9to1_8.Protocol1_9To1_8;
 import com.viaversion.viaversion.rewriter.SoundRewriter;
+import java.util.logging.Level;
 
 public class Protocol1_12To1_11_1 extends AbstractProtocol<ClientboundPackets1_9_3, ClientboundPackets1_12, ServerboundPackets1_9_3, ServerboundPackets1_12> {
 
@@ -105,7 +106,7 @@ public void register() {
 
                 wrapper.set(Type.COMPONENT, 0, obj);
             } catch (Exception e) {
-                e.printStackTrace();
+                Via.getPlatform().getLogger().log(Level.WARNING, "Error converting 1.11.2 -> 1.12 chat item", e);
             }
         });
 
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/Protocol1_13To1_12_2.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/Protocol1_13To1_12_2.java
@@ -69,6 +69,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.logging.Level;
 
 public class Protocol1_13To1_12_2 extends AbstractProtocol<ClientboundPackets1_12_1, ClientboundPackets1_13, ServerboundPackets1_12_1, ServerboundPackets1_13> {
 
@@ -182,7 +183,7 @@ public void register() {
                         }
                         wrapper.set(Type.STRING, 0, GsonUtil.getGson().toJson(json));
                     } catch (JsonParseException e) {
-                        e.printStackTrace();
+                        Via.getPlatform().getLogger().log(Level.SEVERE, "Error transforming status response", e);
                     }
                 });
             }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/data/BlockIdData.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/data/BlockIdData.java
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/storage/TabCompleteTracker.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_13to1_12_2/storage/TabCompleteTracker.java
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/packets/PlayerPackets.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/packets/PlayerPackets.java
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/packets/SpawnPackets.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/packets/SpawnPackets.java
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/storage/EntityTracker1_9.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_9to1_8/storage/EntityTracker1_9.java
diff --git a/common/src/main/java/com/viaversion/viaversion/update/UpdateUtil.java b/common/src/main/java/com/viaversion/viaversion/update/UpdateUtil.java
diff --git a/velocity/src/main/java/com/viaversion/viaversion/velocity/platform/VelocityViaInjector.java b/velocity/src/main/java/com/viaversion/viaversion/velocity/platform/VelocityViaInjector.java
diff --git a/velocity/src/main/java/com/viaversion/viaversion/velocity/providers/VelocityVersionProvider.java b/velocity/src/main/java/com/viaversion/viaversion/velocity/providers/VelocityVersionProvider.java
diff --git a/velocity/src/main/java/com/viaversion/viaversion/velocity/service/ProtocolDetectorService.java b/velocity/src/main/java/com/viaversion/viaversion/velocity/service/ProtocolDetectorService.java
diff --git a/velocity/src/main/java/com/viaversion/viaversion/velocity/storage/VelocityStorage.java b/velocity/src/main/java/com/viaversion/viaversion/velocity/storage/VelocityStorage.java

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`import com.viaversion.viaversion.protocols.protocol1_9to1_8.ClientboundPackets1_9;`
`26`	`26`	`import com.viaversion.viaversion.protocols.protocol1_9to1_8.Protocol1_9To1_8;`
`27`	`27`	`import java.util.UUID;`
	`28`	`+import java.util.logging.Level;`
`28`	`29`	`import org.bukkit.Bukkit;`
`29`	`30`	`import org.bukkit.entity.HumanEntity;`
`30`	`31`	`import org.bukkit.entity.Player;`
`@@ -71,7 +72,7 @@ public void sendArmorUpdate(Player player) {`
`71`	`72`
`72`	`73`	`wrapper.scheduleSend(Protocol1_9To1_8.class);`
`73`	`74`	`} catch (Exception e) {`
`74`		`- e.printStackTrace();`
	`75`	`+ Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send armor update", e);`
`75`	`76`	`}`
`76`	`77`	`}`
`77`	`78`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@`
`30`	`30`	`import org.bukkit.event.EventPriority;`
`31`	`31`	`import org.bukkit.event.entity.PlayerDeathEvent;`
`32`	`32`	`import org.bukkit.plugin.Plugin;`
	`33`	`+import java.util.logging.Level;`
`33`	`34`
`34`	`35`	`public class DeathListener extends ViaBukkitListener {`
`35`	`36`
`@@ -66,7 +67,7 @@ private void sendPacket(final Player p, final String msg) {`
`66`	`67`
`67`	`68`	`wrapper.scheduleSend(Protocol1_9To1_8.class);`
`68`	`69`	`} catch (Exception e) {`
`69`		`- e.printStackTrace();`
	`70`	`+ Via.getPlatform().getLogger().log(Level.WARNING, "Failed to send death message", e);`
`70`	`71`	`}`
`71`	`72`	`}`
`72`	`73`	`});`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`package com.viaversion.viaversion.bukkit.platform;`
`19`	`19`
`20`	`20`	`import com.google.common.base.Preconditions;`
	`21`	`+import com.viaversion.viaversion.api.Via;`
`21`	`22`	`import com.viaversion.viaversion.bukkit.handlers.BukkitChannelInitializer;`
`22`	`23`	`import com.viaversion.viaversion.bukkit.util.NMSUtil;`
`23`	`24`	`import com.viaversion.viaversion.platform.LegacyViaInjector;`
`@@ -30,6 +31,7 @@`
`30`	`31`	`import java.lang.reflect.Field;`
`31`	`32`	`import java.lang.reflect.Method;`
`32`	`33`	`import java.util.List;`
	`34`	`+import java.util.logging.Level;`
`33`	`35`	`import org.bukkit.Bukkit;`
`34`	`36`	`import org.bukkit.plugin.PluginDescriptionFile;`
`35`	`37`	`import org.checkerframework.checker.nullness.qual.Nullable;`
`@@ -217,7 +219,7 @@ public boolean isBinded() {`
`217`	`219`	`}`
`218`	`220`	`}`
`219`	`221`	`} catch (ReflectiveOperationException e) {`
`220`		`- e.printStackTrace();`
	`222`	`+ Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to check if ViaVersion is binded", e);`
`221`	`223`	`}`
`222`	`224`	`return false;`
`223`	`225`	`}`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public boolean sendPacketToServer(Player p, Object packet) {`
`153`	`153`	`// send`
`154`	`154`	`packetMethod.invoke(playerConnection, packet);`
`155`	`155`	`} catch (IllegalAccessException \| InvocationTargetException e) {`
`156`		`- e.printStackTrace();`
	`156`	`+ Via.getPlatform().getLogger().log(Level.SEVERE, "Failed to send packet to server", e);`
`157`	`157`	`return false;`
`158`	`158`	`}`
`159`	`159`	`return true;`