Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - list direct messages #8

Merged
merged 4 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@ryanckulp
Copy link
Contributor

commented Mar 5, 2019

addresses #7

let me know how final object in collection should look, currently:

{
  thread_id: 'xxx',
  recipient_username: thread.users.first.username, # possible to have 1+
  conversations: [collection of back/forth messages oldest --> newest]
}

will write tests after your opinion.

@ryanckulp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

@VicoErv hey there, are you still opening to reviewing this as promised? if not i can kill + start a new edition.

@VicoErv VicoErv merged commit 6e414d1 into VicoErv:master Mar 11, 2019

@VicoErv

This comment has been minimized.

Copy link
Owner

commented Mar 11, 2019

thank you, i just back from my holiday. You can hard fork this repo and start new edition as you wish. Because i'm not actively maintain

@ryanckulp ryanckulp deleted the ryanckulp:feature/read_direct_messages branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.