From e136502b7b6a82fee1b4ee03a521c435199e2410 Mon Sep 17 00:00:00 2001 From: Victor Hom Date: Tue, 6 Jun 2017 12:46:21 -0400 Subject: [PATCH] New: WIP add eslintIgnore support to package.json (fixes #8458) More tests required --- lib/ignored-paths.js | 7 ++++--- tests/lib/ignored-paths.js | 5 ++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/ignored-paths.js b/lib/ignored-paths.js index 140beb7f2d54..0aabb2353a45 100644 --- a/lib/ignored-paths.js +++ b/lib/ignored-paths.js @@ -183,9 +183,10 @@ class IgnoredPaths { const configOptions = config.load(packageJSONPath, configContext); if (configOptions.eslintIgnore) { - const filesToIgnore = configOptions.eslintIgnore; - - debug(filesToIgnore); + configOptions.eslintIgnore.forEach( pattern => { + addPattern(this.ig.custom, pattern); + addPattern(this.ig.default, pattern); + }); } } } catch (e) { diff --git a/tests/lib/ignored-paths.js b/tests/lib/ignored-paths.js index 48048457cff5..64e2ff2ae79d 100644 --- a/tests/lib/ignored-paths.js +++ b/tests/lib/ignored-paths.js @@ -165,9 +165,12 @@ describe("IgnoredPaths", () => { ); }); - it("shoud load package.json's array of files to ignore in eslintIgnore", () => { + it("should load package.json's array of files to ignore in eslintIgnore", () => { const expectedIgnoreFile = getFixturePath("package-json-ignore/package.json"); const ignoredPaths = new IgnoredPaths({ ignore: true, cwd: getFixturePath("package-json-ignore") }); + + assert.isTrue(ignoredPaths.contains("hello.js")); + assert.isTrue(ignoredPaths.contains("world.js")); }); });