Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui restores previous query in a new browser session #1694

Closed
Nastradamus opened this issue Oct 12, 2021 · 4 comments
Closed

vmui restores previous query in a new browser session #1694

Nastradamus opened this issue Oct 12, 2021 · 4 comments
Labels
enhancement New feature or request vmui

Comments

@Nastradamus
Copy link

Describe the bug

In the VM single 1.67 I see a bug: if open a new tab in browser with /vmui, it restores previous query from cookies (I think).

To Reproduce

  • Open http://instance-ip:8189/vmui/
  • Enable Autocomplete
  • Perform a PromQL query
  • Open a new tab and open http://instance-ip:8189/vmui/ : vmui will execute query from previous session

This is also confirmed in the private browser mode.

Expected behavior
No saved queries in cookies.

Version

victoria-metrics-prod --version
victoria-metrics-20211008-135230-tags-v1.67.0-0-g6058edb0d
@valyala valyala added vmui enhancement New feature or request labels Oct 12, 2021
@valyala
Copy link
Collaborator

valyala commented Oct 12, 2021

vmui remembers the last executed query in browser local storage. Agreed that it would be better to disable saving the last executed query, since it has little usability while increases distraction.

@valyala
Copy link
Collaborator

valyala commented Oct 20, 2021

@Loori-R , could you look into this issue?

@valyala
Copy link
Collaborator

valyala commented Nov 29, 2021

The issue must be fixed in the commit c6d5927 , which will be included in the next release of VictoriaMetrics.

@valyala
Copy link
Collaborator

valyala commented Dec 2, 2021

vmui shouldn't persist queries across restarts starting from v1.70.0. Closing the issue as fixed.

@valyala valyala closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vmui
Projects
None yet
Development

No branches or pull requests

2 participants