Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: title may be improperly updated in the tooltip when hovering graph lines #3530

Closed
valyala opened this issue Dec 24, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working vmui

Comments

@valyala
Copy link
Collaborator

valyala commented Dec 24, 2022

Describe the bug

Sometimes vmui leaves the previous title for the graph line after quick mouse move from one line to another.

To Reproduce

  1. Open https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/?g0.expr=(%0A%20%20alias(running_sum(rand(1)%20-%200.5)%2C%20%22r1%22)%2C%0A%20%20alias(running_sum(rand(2)%20-%200.5)%2C%20%22r2%22)%2C%0A)&g0.range_input=3h&g0.end_input=2022-12-24T06%3A02%3A09&g0.relative_time=last_3_hours
  2. Hover the r1 graph around the point where r1 graph crosses the r2 graph. Note that the graph title is correct in the appeared tooltip, e.g. it is r1.
  3. Move the mouse to the closest point of the r2 graph. Note that the graph title is incorrect in the appeared tooltip, e.g. it is r1 instead of r2.

Expected behavior

The graph title should be properly updated to r2 when hovering r2 line.

Possible workaround

Move the cursor outside graph lines and then return the cursor back to r2 graph. The graph title in the appeared tooltip becomes correct, e.g. it is r2.

@valyala valyala added bug Something isn't working vmui labels Dec 24, 2022
valyala added a commit that referenced this issue Dec 29, 2022
valyala added a commit that referenced this issue Dec 29, 2022
@valyala
Copy link
Collaborator Author

valyala commented Dec 29, 2022

The bug has been fixed in b8bc624 . The commit will be included in the next release of VictoriaMetrics. In the mean time it is possible to build VictoriaMetrics from this commit according to these instructions and verify the bug is properly fixed.

@valyala
Copy link
Collaborator Author

valyala commented Jan 11, 2023

The bug has been fixed in v1.86.0. Closing it then.

@valyala valyala closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vmui
Projects
None yet
Development

No branches or pull requests

2 participants