Permalink
Browse files

Fix other crashes : moved the BrowserPane retain earlier in the proce…

…ss of opening a new tab.

Note : clicking a download link or a RSS link opens a blank tab which does not provoke didCommitLoadForFrame. When closed, such a tab was overreleased.
  • Loading branch information...
1 parent 4450750 commit 1d5226a454852568ee0b89c14a77cf5fea06fac1 @barijaona barijaona committed Sep 7, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 BrowserPane.m
View
@@ -293,6 +293,7 @@ -(void)webView:(WebView *)sender didStartProvisionalLoadForFrame:(WebFrame *)fra
[self showRssPageButton:NO];
[self setError:nil];
[self setViewTitle:@""];
+ [self retain];
}
}
@@ -336,7 +337,6 @@ -(void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
else
[addressField setStringValue:[[[frame dataSource] unreachableURL] absoluteString]];
- [self retain];
}
}

0 comments on commit 1d5226a

Please sign in to comment.