UnifiedDisplayView improvement : smoother scrolling, less mispositioned cells.
This seems to solve efficiently the "shifted cell" problem. So we remove many unneeded tricks.
webView:didFailLoadWithError:forFrame: and non relevant cell
Finer management of rowHeightArray, when a bottom cell get finished before upper cells. Conflicts: src/UnifiedDisplayView.m
- adjust management of ArticleCellView's inProgress property - store and use as soon as possible the pieces of information used to detect non relevant cells - remove strange tricks in -listView:cellForRow - no wait time when dimension problem is detected
- remove all setNeedsDisplay tricks : MacOS X probably knows better than me - standardize initial size of cells
- simplified start of Webview handling - add article's row management in ArticleCellView - change the way we detect a non relevant cell (check our article's folder Id and row) - fix Webview error handling - fix an exception
Improve accessibility of feed list and article list. Thanks to @dusek !
Per @barijaona’s feedback
This is a bit of a hack as we are using AXDescription for this. Overriding AXValue is not viable without much more code because all dependent parameterized attributes (AXAttributedStringForRange etc.) would need to be adjusted as well. Cleaner solution can IMHO be implemented only after transitioning to a view-based outline and have each element (error image, progress image, count label, feed name, folder image) available as a subview of the cell’s view and provide its own part of accessibility information. (E.g. as in Mail's mesage list). For now, this quite works :-)
I named the feeds table “Feeds” but if Vienna uses other term for them (e.g. Folders, I am not sure as I don’t use Vienna myself), please adjust it or tell me to do so.
Password related bugfixes
Reverse commit 56f3aae and fix detection of feeds using username/password. See http://forums.cocoaforge.com/viewtopic.php?t=26440&p=137699#p137699 and http://forums.cocoaforge.com/viewtopic.php?f=18&t=25229&p=135848#p135168
The correct icns is now named vienna-3
Seems to solve http://www.cocoaforge.com/viewtopic.php?f=18&t=26440
Fix needed by Inoreader.com
Instead of waiting calls to webView:didFinishLoadForFrame: as a frameLoadDelegate, we register for notifications of WebViewProgressFinishedNotification. webView:didFinishLoadForFrame: seems to be called early on OS X, even when ensuring the frame parameter is the main frame: <http://stackoverflow.com/questions/12120772/how-to-know-when-a-webview-has-finished-rendering>
Fix progress indicator Performance optimization of -(PXListViewCell*)listView:(PXListView*)aListView cellForRow:(NSUInteger)row Limit as much as possible forced display refreshes Reviewed and simplified treatment of problematic cases Avoid call to private methods of PXListView