Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnclosureView contracts to shortest width #1082

Open
jeanravin opened this issue Feb 6, 2018 · 36 comments

Comments

Projects
None yet
7 participants
@jeanravin
Copy link

commented Feb 6, 2018

Since 3.2.1 (using macOS 10.10.5) I have this bug happening only on articles with linked files , if I click an article the right column is retracted to the far right. If I try to resize it, it will still collapse to the right.

2018-02-06015822 vienna-vienna

@Eitot

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2018

Can you share the feed URL?

@jeanravin

This comment has been minimized.

Copy link
Author

commented Feb 8, 2018

@mvilain

This comment has been minimized.

Copy link

commented Feb 8, 2018

I can confirm this problem on 10.10.5. It's why a downgraded to Vienna 3.1.16. I'll stay there until this is fixed.

@Eitot

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

This appears to be isolated to particular versions of macOS. I cannot confirm this on Sierra nor High Sierra. I am guessing that this is an Auto Layout issue with the stack view.

@mu-is-too-short

This comment has been minimized.

Copy link

commented Feb 10, 2018

I'm seeing the same issue on macOS 10.10.5 with Vienna 3.2.1 on:

http://feeds.feedburner.com/tedtalks_video

Vienna 3.2.0 seems fine with it.

@jeanravin

This comment has been minimized.

Copy link
Author

commented Feb 10, 2018

Vienna 3.2.0 seems fine with it.

Indeed.

@Eitot

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

That is bizarre. There are barely any changes between 3.2.0 and 3.2.1, at least none that touch upon the UI there.

@mvilain

This comment has been minimized.

Copy link

commented Feb 10, 2018

Tired to get into the CocoaForge Forum but it didn't like the antispam question, so forgetaboutit.

Anyway, these are all moot since I can't build form 3.2 sources and there's only the beta binary. Unless there's an offical 3.2 binary somewhere, I'm sticking to 3.1.6 until this is fixed on 10.10.5.

@jeanravin

This comment has been minimized.

@rawtaz

This comment has been minimized.

Copy link

commented Feb 10, 2018

It's happening for me on an OS X 10.9.5 machine as well, so it's not just OS X 10.10.5. Same there, started after upgrading from 3.2.0 to 3.2.1.

@josh64x2

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

I just tested on a VM for 10.10.5 and I was able to reproduce. This was with version 3.2.0 beta 1.
When I try to resize the columns it snaps straight back to the bad layout similar to the screenshot in the main issue.

Unfortunately there is nothing in the logs.

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

Is it possible to examine the preferences file ?

@josh64x2

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

@josh64x2 josh64x2 added the bug 🐛 label Feb 11, 2018

@Eitot Eitot self-assigned this Feb 11, 2018

@Eitot Eitot changed the title columns bug with linked files EnclosureView contracts to shortest width Feb 11, 2018

@Eitot

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2018

I think I have come up with a solution. It was a misconfiguration of the labels in Interface Builder.

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

Does the problem appear in 3.2.1 only ? I see no reason for the problem to appear in 3.2.1 and not in 3.2.0

@rawtaz

This comment has been minimized.

Copy link

commented Feb 20, 2018

@barijaona Yes, it happens in 3.2.1 but not in 3.2.0, and this is for multiple people on different versions of OS X/macOS.

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

@mvilain You wrote you stick with 3.1.16 for the time being. Did you try 3.2.0 and notice this problem with it ?

@rawtaz

This comment has been minimized.

Copy link

commented Feb 20, 2018

@barijaona FWIW, I have both 3.2.0 and 3.2.1 installed. The former works fine, the latter doesn't. I'm not sure why you have a hard time agreeing it started happening after 3.2.0. The symptoms are 100% clear here at least. I can reproduce it 100%, by switching from 3.2.0 to 3.2.1.

@rawtaz

This comment has been minimized.

Copy link

commented Feb 20, 2018

@Eitot Can you elaborate - is a fix submitted anywhere, perhaps even merged to master?

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

@rawtaz because when I compare 3.2.1 source to 3.2.0, I see strictly no change related to this specific window (look at the "Files changed" tab).

@rawtaz

This comment has been minimized.

Copy link

commented Feb 20, 2018

@barijaona Right, I understand that. Other devs said the same if you read above. Despite that though, there's no disputing that the problem started happening with 3.2.1. It's not likely that it's just a random coincidence that it started happening with that specific version for multiple people on multiple platforms. Let's see what @Eitot replies, as he said he found the problem and fixed it.

@Eitot

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2018

I thought I had fixed it, but it caused other issues elsewhere. Then I found out that sometimes the solution worked and sometimes it didn’t, even between builds. I am suspecting that there might be something else, perhaps a build issue. That would explain why this problem started appearing only in 3.2.1, even though the source did not even touch the XIB file.

@mu-is-too-short

This comment has been minimized.

Copy link

commented Feb 20, 2018

@barijaona I see a layout resizing problem with Vienna 3.2.1 on macOS 10.10.5, Vienna 3.2.0 works fine. I don't see the exact problem problem as jeanraven though, my left and right panes keep resizing themselves to be the same width when there's an attachment. I'm using the Horizontal layout and FeedLight Aqua style if that's relevant.

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

A build issue is possible, as I have recently noticed some mysterious problems that could be solved by removing and rebuilding my ~/Library/Developer/Xcode/DerivedData/ModuleCache/ folder. I have rebuilt a 3.2.1 here. Can you try it ?

Vienna3.2.1.tar.gz

@mu-is-too-short

This comment has been minimized.

Copy link

commented Feb 21, 2018

@barijaona I just tried that build of 3.2.1 and it seems to be behaving itself for me. Nice one.

@jeanravin

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

@barijaona I confirm, this build fix the bug.

@barijaona

This comment has been minimized.

Copy link
Member

commented Feb 22, 2018

The new build has been uploaded to Github, Sourceforge and Bintray.

@barijaona barijaona closed this Feb 22, 2018

@rawtaz

This comment has been minimized.

Copy link

commented Feb 22, 2018

The new build solved the problem on OS X 10.9.5. Thanks!

@jeanravin

This comment has been minimized.

Copy link
Author

commented Apr 1, 2018

Oops, it's happening again with 3.3.0 …

@barijaona

This comment has been minimized.

Copy link
Member

commented Apr 1, 2018

A corrupted cache during build again ? Could you try this one ?
Vienna3.3.0.tar.gz

@barijaona barijaona reopened this Apr 1, 2018

@jeanravin

This comment has been minimized.

Copy link
Author

commented Apr 2, 2018

@barijaona Alas, still not behaving correctly here… Staying with 3.2.1 for now.

@barijaona

This comment has been minimized.

Copy link
Member

commented Apr 2, 2018

@jeanravin you are still running 10.10.5 ?

@rawtaz

This comment has been minimized.

Copy link

commented Apr 2, 2018

FWIW, 10.9.5 here, same problem.

@jeanravin

This comment has been minimized.

Copy link
Author

commented Apr 2, 2018

@barijaona still

@rawtaz

This comment has been minimized.

Copy link

commented Jun 29, 2018

@barijaona Can you publish a corrected build of 3.3.0? This issue is still active in the current 3.3.0 download in the releases on GitHub.

@barijaona

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Related : apparently this problem reappeared in 3.5.1 but is not present in 3.5.0
https://forums.cocoaforge.com/viewtopic.php?t=27111
https://forums.cocoaforge.com/viewtopic.php?t=27117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.