New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article with fields containing emoji are pushed down in article list views (vertical/horizontal layout) #447

Closed
phiw13 opened this Issue Mar 26, 2015 · 6 comments

Comments

5 participants

@barijaona barijaona added the bug 🐛 label Nov 27, 2016

@barijaona barijaona added this to the v3.2.0 milestone Nov 27, 2016

@barijaona barijaona changed the title from article author field containing emoji is pushed down in article list views (vertical/horizontal layout) to Article with fields containing emoji are pushed down in article list views (vertical/horizontal layout) Dec 18, 2016

@josh64x2 josh64x2 added this to Backlog in Modernise UI Apr 14, 2017

@josh64x2 josh64x2 self-assigned this Jul 15, 2017

@barijaona barijaona modified the milestones: v3.2.0, backlog Jan 28, 2018

@RobFog

This comment has been minimized.

@karlcow

This comment has been minimized.

karlcow commented May 21, 2018

This is another example

capture d ecran 2018-05-21 a 11 05 56

@karlcow

This comment has been minimized.

karlcow commented May 21, 2018

Is this related to the issue?

- (NSRect)titleRectForBounds:(NSRect)theRect {
/* get the standard text content rectangle */
NSRect titleFrame = [super titleRectForBounds:theRect];
/* find out how big the rendered text will be */
NSRect textRect = [self.attributedStringValue boundingRectWithSize: titleFrame.size
options: NSStringDrawingUsesLineFragmentOrigin | NSStringDrawingDisableScreenFontSubstitution];
CGFloat tHeight = textRect.size.height;
CGFloat fHeight = titleFrame.size.height;
/* If the height of the rendered text is less then the available height,
* we modify the titleFrame to center the text vertically */
if (tHeight < fHeight) {
titleFrame.origin.y = theRect.origin.y + (theRect.size.height - tHeight )/2.0;
titleFrame.size.height = tHeight;
} else {
if (tHeight < 1.5 * fHeight)
{
titleFrame.origin.y = theRect.origin.y + (fHeight - tHeight);
titleFrame.size.height = tHeight;
}
}
return titleFrame;
}

@karlcow

This comment has been minimized.

karlcow commented May 21, 2018

@barijaona

This comment has been minimized.

Member

barijaona commented Oct 16, 2018

As a consequence of studying removal of hard coded colors in order to improve dark mode, I finally found a solution to this long standing and annoying bug…
@josh64x2, I think it's safe enough to be included in 3.5.0 (will have to test it tonight on my 10.9 virtual box though…). Your opinion ?

@phiw13

This comment has been minimized.

phiw13 commented Oct 17, 2018

As a consequence of studying removal of hard coded colors in order to improve dark mode, I finally found a solution to this long standing and annoying bug…

Works well so far in 3.5.0. Big thanks!

@barijaona barijaona closed this Oct 17, 2018

Modernise UI automation moved this from Backlog to Done Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment