Make all images use Fixed direction #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue ViennaRSS#1052 by changing all image asset images to have direction of "Fixed"
|
Verified on 10.10.5 |
|
Great job, Josh ! I am curious to know how you found this idea ! |
barijaona
approved these changes
Dec 18, 2017
|
@barijaona - I saw the settings on Saturday when looking at the first bug report, and eitot mentioned it to me as well but I didn't think to verify until I saw your screenshot of the missing icons in the toolbar. Sure enough, the missing icons were the ones with the different Direction value set and then that seemed to solve the crash :) |
barijaona
added a commit
that referenced
this pull request
Jan 28, 2018
Squashed commit of the following:
commit 741623339bba1f41ff8944346239d8d414ad72f5
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 27 23:56:47 2018 +0300
Upgrade version number to 3.2.0
commit 8d33bae497a88585c8eecb5eb817dda35b512276
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 27 21:41:31 2018 +0300
Use .tgz file extension for archives to download
This makes things easier for the user to directly get the application.
This change is basically a reverse of commit 616b7db.
commit a91cc89d2f52f0c70f4d7e18f66b1023897059f9
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jan 25 04:43:49 2018 +0300
Upgrade version number to 3.2.0 rc 1
commit 0d42a8d92784d6f090f2a12dec13d76363e8121b
Merge: de353118 f59b44e1
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Wed Jan 24 18:42:36 2018 +0800
Merge pull request #1064 from barijaona/issue-1063
Fix OpenReader error handling
commit de3531187974d799096a6c65f1a81bb0f0b7ec90
Merge: 8a2d2cbe e2d2da4e
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Wed Jan 24 18:42:19 2018 +0800
Merge pull request #1065 from barijaona/noTabAnimation
Remove tab animation
commit 8a2d2cbebc101138aa182919de76d9a5749c7ddd
Merge: 6fe72c50 ed50cb43
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Wed Jan 24 17:36:42 2018 +0800
Merge pull request #1066 from barijaona/copyright
Update copyright informations
commit ed50cb43cf636a1e9e1c02fd22e754cffa3a026c
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jan 21 21:26:14 2018 +0300
Update some copyright informations
commit e2d2da4e5eb17ab258c4b8e1dd83b822724f9e01
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 20 21:59:04 2018 +0300
Remove tab animation
As discussed at issue #1060
commit f59b44e15505a42e372ec6ca7c1c77644e594bd3
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 20 21:22:10 2018 +0300
Notify user of OpenReader login errors
commit aa0ef627932ab0375aa06308f694080371e4de72
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 20 20:36:19 2018 +0300
Fix use of clearDelegatesAndCancel
One can notice occasional mismatches in numbers of -addConnection and
connection ends. So to the user, it seems that Vienna never finishes
its work.
Fix found after reading ASIHTTPRequest documentation.
commit 6fe72c50541a7d4636a511d9c84508d07132aa7a
Merge: e0198e84 10013fc1
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jan 20 21:37:26 2018 +0300
Merge pull request #1059 from barijaona/psmtabbar
Update PSMTabBarControl.framework
commit 10013fc191a2b8099cc38457e669f4cc3d7b787d
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jan 7 17:05:20 2018 +0300
Update PSMTabBarControl.framework to version 1.4
Cf. https://github.com/barijaona/PSMTabBarControl
commit e0198e84a216066217a322461d2fb752b01cccbb
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jan 7 17:15:08 2018 +0300
Upgrade version number to 3.2.0 Beta 3
commit fbbe55c50d05ff81d297bd11ec07dd1cc959548c
Merge: d4595e46 881dca7d
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Fri Jan 5 08:48:51 2018 +0800
Merge pull request #1058 from barijaona/bugfixes
Fix persistent tab bar at launch
commit 881dca7d81864c86a66492d92b2147fe178ea590
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Fri Dec 29 06:55:45 2017 +0800
Fix persistent tab bar at launch
Partially reverse commit 24dd91d to solve issue #1054
https://forums.cocoaforge.com/viewtopic.php?t=27039&p=140243#p140243
commit d4595e46c8d83ddc2c6f288698eeb327b95b4a37
Merge: f027c192 c8c3dd2b
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Sat Dec 23 08:04:57 2017 +0800
Merge pull request #1056 from Eitot/swiftlint
Update .swiftlint.yml for version 0.24
commit f027c192691495977575ec304d89ffb3f9a4699c
Merge: e773490b 1be71f3f
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Sat Dec 23 08:03:35 2017 +0800
Merge pull request #1057 from Eitot/pods
Update FMDB to 2.7.4 and remove OCMock
commit 1be71f3f2e90c9948c4cd36ddee83be1d75b43e4
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Dec 22 14:58:59 2017 +0100
Update FMDB to 2.7.4 and remove OCMock
commit c8c3dd2b3e432fa393c97e89a692782e4982b21a
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Dec 22 13:56:06 2017 +0100
Update .swiftlint.yml for version 0.24
commit e773490b6fe1fcecea2ff0908a404bad6c161acf
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Dec 18 22:01:16 2017 +0300
Upgrade credits and version number to 3.2.0 Beta 2
commit e577ea5e92364f2691dd9fd3e95dc63f78014ccd
Merge: 29f38f52 c096e42b
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Dec 18 19:09:24 2017 +0300
Merge pull request #1053 from josh64x2/travis-updates
Updated travis config for xcode 9.2 and build stages
commit 29f38f521f1bcd1c53d67271e47c90f9f53c79ff
Merge: c1d9f7e5 7f2279dc
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Dec 18 19:04:12 2017 +0300
Merge pull request #1055 from josh64x2/issue-1052-fix
Make all images use Fixed direction.
This fix crashes on systems prior to Sierra.
commit 7f2279dc7dc783cc6603f79408db5498d72d3fa2
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Mon Dec 18 18:45:23 2017 +0800
Make all images use Fixed direction
Fixes issue #1052 by changing all image asset images to have direction of "Fixed"
commit c096e42b2a931e9b7aeccf46ba51c28e77b35eb4
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Sat Dec 16 18:12:17 2017 +0800
Updated travis config for xcode 9.2 and build stgs
Build stages as per https://docs.travis-ci.com/user/build-stages/
commit c1d9f7e5434dadc87c8cebd44d53cf24c51f45d7
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Apr 24 03:10:45 2017 +0300
Fix date handling in release script
commit 6601631ed2f304222da49f4266165fb4a2a1becb
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Dec 3 10:45:44 2017 +0300
Notes for initial 3.2.0 beta version
CHANGES file based on version from stable branch
commit b5a982e844e7949366ac2a2a45ec304b2d06e7ce
Merge: dc2400f5 059ce9d3
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Dec 16 08:48:26 2017 +0300
Merge pull request #1046 from barijaona/localizations
New Crowdin translations
commit dc2400f5dd3ae95bb8648b2011108ddb2dacabf8
Merge: e5f6ec7e 5730bb3a
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Thu Dec 7 07:44:31 2017 +0800
Merge pull request #1043 from barijaona/bugfixes
Silence a warning and prettify routine code
commit 5730bb3a4c36c2fd89433c4aa9d43def3b867cb4
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Dec 3 10:46:38 2017 +0300
Silence a warning and prettify routine code
commit 059ce9d31e768283d4964c74c1b87685e8b83309
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Dec 5 00:30:23 2017 +0300
Re-import localizations
commit 37d143c0851604bb5009375acdd5c60fe2210d6c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Nov 21 14:01:42 2017 +0100
New translations en.xliff (Czech)
commit e5f6ec7edc78d521a75d034e89f287bf63569666
Merge: 119bb774 562bdfaf
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Tue Nov 21 07:55:07 2017 +0800
Merge pull request #1041 from barijaona/useragent
Change user-agent to allow some forbes.com pages to load
commit 562bdfaf6459808d91ad63f02512f7a6698e48f4
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 24 21:42:25 2017 +0300
Change user-agent to let forbes.com pages to load
The `Mozilla/5.0` string in the user agent made connection fail when
loading www.forbes.com pages,
as reported at https://forums.cocoaforge.com/viewtopic.php?f=18&t=27001
The new user agent looks something like :
(Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/12603.3.8 (KHTML, like Gecko) Version/11.0 Safari/604.1.38 Vienna/3.2.0
I have checked that BBC videos load without requiring Adobe Flash.
commit 119bb7741e64df4869e9a56ce85bcead4b154d1c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Nov 12 14:12:42 2017 +0100
New Crowdin translations (#1036)
* New translations en.xliff (Chinese Traditional)
* Re-import localizations
commit 4fd0fe4279ef0009bad8ff7d511b90c8e5ab0f77
Merge: 288a0ece b9119bc1
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Oct 10 06:47:46 2017 +0300
Merge pull request #1034 from Eitot/swift-4
Adopt Swift 4 block-based key-value observation
commit b9119bc193dff736104ab828d076cd891ace0df3
Merge: 181d64ee 288a0ece
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Oct 10 03:02:37 2017 +0300
Merge branch 'master' into swift-4
commit 288a0ece1e11fedd65979ddb30bdb20fe5707d11
Merge: 7d756beb 4786cec2
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Oct 10 02:44:33 2017 +0300
Merge pull request #1033 from Eitot/swiftlint
Support SwiftLint 0.23
commit 7d756bebd551e3f190b3143ea15fc1f62e3e19f6
Merge: 0def4935 add50f52
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Oct 10 02:43:54 2017 +0300
Merge pull request #1032 from Eitot/housekeeping
Housekeeping
commit 181d64eefd9ac2ccd1f059b3b2867454d02870b5
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Oct 9 22:18:29 2017 +0200
Adopt Swift 4 block-based key-value observation
commit 4786cec27f4f1d472b5fcb8f1e6591933089e4fc
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Oct 9 21:25:23 2017 +0200
Update Swift code to comply with SwiftLint 0.23
commit 9e8b0c4873609210b25083b74cbcaa978fc93682
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Oct 9 21:24:42 2017 +0200
Update .swiftlint.yml for version 0.23
commit add50f527875f6c345037f3522156712ea215e1b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 16 00:00:50 2017 +0200
Sort remaining images by name
commit 060a9cb6583d18892c127edc659756155fecd46c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 23:57:23 2017 +0200
Delete unused images
commit 7ba8652def4a43360fe101d4d59842e188659b83
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 23:45:13 2017 +0200
Delete unused Preferences.plist file
commit 1cc338045df9240085b38494e145677ada4e169e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 23:44:28 2017 +0200
Remove codesignrequirement.rqset from Xcode project
commit 0def493571e26400c09a7d160718be146b8626b7
Merge: 5ba9e344 caed4e0e
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Oct 8 10:18:51 2017 +0300
Merge pull request #1031 from barijaona/bugfixes
Reduce synchronization work on folder refresh
commit caed4e0ed9d3543f57118a4154392d64dcc0bc42
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Oct 7 04:25:06 2017 +0300
Reduce synchronization work on folder refresh
No need to manually synchronize anymore, because since commit
d7f50f0144a180b4cee0db1ba3dde29c91ef0328, count properties are atomic.
commit 5ba9e344e7e2b28fe78e08440c9d153cdf8ccbd6
Merge: a6ed2694 0251c2c9
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Oct 5 03:37:45 2017 +0300
Merge pull request #1030 from barijaona/docs
Docs
commit a6ed269431095dccf195a7def35c8ec0ac1dee9b
Merge: 2597cbe5 df5d2abe
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Oct 5 03:36:23 2017 +0300
Merge pull request #1027 from barijaona/bugfixes
Fix deprecation warnings on dragging methods
commit 2597cbe5c73550cafc68bc676d07f0524fb9a851
Merge: 1d0d97c0 82e49f35
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Oct 4 21:31:49 2017 +0300
Merge pull request #1028 from Eitot/build-warning
Fix build warning in InfoPanelController.m
commit 0251c2c965f572d27b0f38415c389559bcf83fae
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Sep 26 02:32:21 2017 +0300
Update release instructions.
commit 4cc5e603e388f44c57392465b6e75900422776ec
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Oct 4 21:15:37 2017 +0300
Info on dSYM files & clarify code style guidelines
commit 0ec2548911925a960120896f6f5ed4cc48be321d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Oct 4 06:39:06 2017 +0200
Update documentation for Xcode 9/Swift 4
Also remove some redundancies and/or discrepancies between README.md and
CONTRIBUTING.md
commit 82e49f35c066ece013ed895d115e347ba0b86d4c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Oct 4 06:05:12 2017 +0200
Fix build warning in InfoPanelController.m
commit df5d2abe8e56034ac3180a7f9a57ad781837088d
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Oct 4 06:38:51 2017 +0300
Fix deprecation warnings on dragging methods
commit 1d0d97c0dff3e62b52de812363ebf6cad6d32ba7
Merge: e432c02d 4083ab33
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Oct 4 05:15:49 2017 +0300
Merge pull request #1025 from Eitot/swift-4
Adopt Swift 4
commit e432c02db1794353d85a56077801efd0dc6e0fe8
Merge: cfb5414e d7f50f01
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Oct 4 03:55:46 2017 +0300
Merge pull request #1014 from barijaona/bugfixes
Port of stable version 3.1.15 and 3.1.16 bug fixes to master
commit cfb5414e3faf8604e8eda26711791381f5594256
Merge: 79d27974 22b2cf04
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Wed Oct 4 09:11:59 2017 +1100
Merge pull request #1026 from Eitot/travis
Modify Travis configuration for Xcode 9 and SwiftLint
commit 4083ab337a951628a29636e9aa7290c6a1efa939
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 21:17:40 2017 +0200
Remove Swift 3 workaround from Podfile
commit 5bca37cbe08a43cebc706e13f11ddff1bf5f1367
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 18:22:20 2017 +0200
Enable method deprecation warnings
commit 4eeb57589f3268326ace2fa010e8b04c2b3a956a
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 18:10:29 2017 +0200
Use availability syntax in Objective-C
commit 7731c530f75f93fd05e38af605c93c22e0e8b912
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 18:06:19 2017 +0200
Enable API availability check
commit 4f4a33b42ba2cc3ed69b25d68eac4978c0ec17cf
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 17:40:41 2017 +0200
Update .swiftlint.yml for version 0.22
commit 80cbd30a3ca1c9c224566214a5b59c388f0ef17a
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Oct 1 18:19:48 2017 +0200
Convert project to Swift 4
commit 4158316761c65a4a61ff9777a05174b4b99d88bf
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Oct 1 18:02:27 2017 +0200
Apply Xcode project recommendations
commit 22b2cf042b8f66e9a68288c1376cfc91ea66ba41
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 20:04:23 2017 +0200
Configure Travis to update SwiftLint
commit e1cf830978e60e5852b4af087d19e747647f9a7f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Oct 3 20:04:02 2017 +0200
Configure Travis to use Xcode 9/10.13 SDK
commit d7f50f0144a180b4cee0db1ba3dde29c91ef0328
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 24 04:11:02 2017 +0300
Make Folder’s count properties thread safe
Issue #1019
commit 8bcb6968a97bfcb36dcf3f90474faa04f3760313
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Sep 21 08:03:29 2017 +0300
Fix change of selection after article deletion
https://forums.cocoaforge.com/viewtopic.php?f=18&t=27010
commit d4098d10d201edb489e9fbd33becb89af2c6b23b
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Wed Sep 13 20:40:19 2017 -0500
Fix selection after 'Skip Folder'.
Fix 'Skip Folder' not selecting the first unread article in the next
folder with unread articles.
commit 7dec77e7c94d71375ca55ada5bc69421b902b523
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Thu Sep 14 20:49:25 2017 -0500
Change folder initialization on folder switch
Fix regression to issue #658 detected by user stern at
http://forums.cocoaforge.com/viewtopic.php?t=26842&p=139450#p140069
commit 79d279749608d0eac461941414e02bc5a755d083
Merge: 30d76c9d 4f342ee7
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Oct 2 16:34:22 2017 +0200
Merge pull request #1024 from Eitot/pods
Update MASPreferences to 1.3.0
commit 30d76c9dc1ac6f49037f6bda7bc408e6b9fea949
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Oct 2 16:33:46 2017 +0200
New Crowdin translations (#1003)
* New translations en.xliff (Swedish)
* Re-import localizations
commit 4f342ee7fecc2068dd61ac629565a27ea1719a90
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Oct 1 17:49:42 2017 +0200
Make code compatible with MASPreferences 1.3.0
commit bd96048bda8f974477aff1b4d4750bcb313d4a84
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Oct 1 17:38:55 2017 +0200
Update MASPreferences to 1.3.0
commit ff923ce33a7cdd8557c1709113f7e77264c49a47
Merge: 567e7508 2c2bf32e
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Wed Sep 20 18:59:38 2017 +1000
Merge pull request #1017 from barijaona/issue-1016
Fix title column width on switch from horizontal to vertical layout
commit 2c2bf32eddd70aff3516c885f9117267e48ef695
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Sep 20 04:37:25 2017 +0300
Remove irrelevant autosaveName from Interface Builder
commit 9878be7b14ec3f5436cb269ab5f367713072dd5f
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Sep 20 01:23:49 2017 +0300
Simplify setting of hidden/shown status for column
commit d8269163f0f0fb34a8bbcf3d875e879cc7699768
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Sep 20 01:24:31 2017 +0300
Remember split view position on orientation switch
commit 0e5fed6b1514dd032f74d48f90bd2aee1cf0ae8a
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Sep 18 08:24:06 2017 +0300
Fix column width on switching to vertical layout
Main fix to issue #1016
Also improved some comments
commit 567e7508a5f2ac5b2e5bb47798b4bca889cacb4d
Merge: 572693cb 4fd9f183
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Sat Sep 16 18:04:42 2017 +1000
Merge pull request #1001 from barijaona/bugfixes
Port of stable version 3.1.13 and 3.1.14 bug fixes to master
commit 572693cb6855f23a3e114464afe277e61443c75a
Merge: ca7d7c6a 245caf72
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Sep 14 20:28:53 2017 +0300
Merge pull request #1006 from barijaona/issue-1005
Fix tests on keys in KVO patterns
commit 4fd9f183834dabb1c32de6e0577d93bc547df1c8
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 11 11:40:42 2017 -0500
Fix assertion failure in removeArticleFromCache when deleting articles from a smart folder.
When you're deleting from a smart folder, the article getting deleted isn't the same as the article in the folder cache, so the (isCached && !theArticle.isDeleted) condition in cache:willEvictObject: is incorrectly true.
commit ab1790d5f2632ce42a516d73d5d49415ce975656
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 11 09:29:13 2017 -0500
Deselect articles before deleting them.
This ensures that the article pane will reload, and avoids article pane
not updating on article deletion from the 'Unread Articles' folder as
reported at https://forums.cocoaforge.com/viewtopic.php?f=18&t=27004
commit b39ed299103d4d6576765844311e7eef9aa3368e
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Tue Sep 5 10:21:02 2017 -0500
Fix Mark All Subscriptions as Read
Articles were not marked as read in Unread Articles smart folder after
Mark All Subscriptions as Read.
This bug was introduced in ce85985a0e4ff8f1b8836293ddea25ebef7ab01a
Also, rename some methods for clarity.
commit 87e0abcf20310b1afc554b123f29d6fbc03fe734
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 4 16:29:14 2017 -0500
Fix bug where a bunch of empty rows appeared in the popup menu.
va_arg did not treat 0 as a CriteriaOperator, so the while loop did not exit when expected.
commit 84df2e1f40b94b2fa7583e1f13dc9fe93f2f350e
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 4 15:43:28 2017 -0500
Delete unnecessary code, because -[SmartFolder doSave:] already checks whether there's another folder with the same name.
commit d6b142c51b631138594656553abe27905637d974
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 4 15:34:31 2017 -0500
Fix bug where smart folders didn't reload after editing their criteria.
This bug was introduced in dc1a1530599702bf9e5c778b87a749c51d823067
commit 63758b3bff2f97c6c8fc3e91ed2f59a4241436d7
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Sep 13 21:15:00 2017 +0300
Use SQLite binding for database search string
This fixes database error with search strings containing a single quote
character.
commit 245caf726f135a27139efd26e871e7def1eb2535
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Sep 13 07:03:22 2017 +0300
Fix tests on keys in KVO patterns
Fix issue #1005
commit 73e0cff334310a8b74db1f8e10b1ce0a3fbc3471
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Tue Sep 5 14:10:32 2017 -0500
Fix for selection of first article on feed jump
(issue #994)
Article loading is now async, so we can't check for selected article
when loading a folder.
commit 3824152544f47507202cb1d8306e6c1b9e1dbf01
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Sep 11 07:00:29 2017 +0300
Slightly better way of preserving selected article.
This handles the situation where there is no selected article when reload begins, but an article gets selected during reload.
commit 4957f80e49690f193d7f19f35ac50389236aec6c
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Mon Sep 4 12:03:03 2017 -0500
Better fix for unwanted article reload (issue #934)
This works for smart folders (like Unread articles)
Also delete unnecessary currentSelectedRow ivar and fix other issues
related to article selection.
commit ca7d7c6a8f28d4121ecaee5f6de59a2680255724
Merge: 45327ebb f048f098
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 10 21:22:02 2017 +0300
Merge pull request #993 from barijaona/bugfixes
Port of 'stable' branch bug fixes to master
commit f048f0982afa3a8a29e44b4532e946cae4636cbe
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Sep 7 04:02:05 2017 +0300
Add braces
commit 45327ebb5715cffbee5302e0c878a6383d3b8d73
Merge: cbaf1560 c20a734a
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Sep 7 03:54:51 2017 +0300
Merge pull request #992 from barijaona/issue-991
Evaluate path of script used to index help book
commit c20a734ad1707b7e4d1a28ebc6d9b64dc96499b6
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 3 16:55:57 2017 +0300
Evaluate path of script used to index help book
Fix issue #991
commit 2bdb9f5d032ef8e750fe4f74cdd2ee3184aea422
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 3 16:26:34 2017 +0300
Maintain current selection on folder refresh
Issue #829
commit 62401e154187b1c43d97a4a2d9d830e549ac3bbb
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Sep 2 14:52:33 2017 +0300
Fix unwanted refresh of article at end of sync
Issue #934
commit 653b2c3b8274c46bd492505fa2373a053913ba31
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Sun Aug 27 10:09:49 2017 -0500
Fix for https://github.com/ViennaRSS/vienna-rss/issues/768
-[NSURL lastPathComponent] is documented as calling stringByReplacingPercentEscapesUsingEncoding. Thus, Vienna was calling it twice, redundantly.
The filename was http://static.giantbomb.com/uploads/screen_medium/0/31/2912034-1467281594-bb2%255.jpg
The last path component was 2912034-1467281594-bb2%5.jpg
When Vienna called stringByReplacingPercentEscapesUsingEncoding on the last path component, it was returning nil. This caused the crash.
commit 76a14eeb0e5c892b03d57cf1f9251fe4389bc4a0
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Sat Aug 26 18:15:41 2017 -0500
Fix for https://github.com/ViennaRSS/vienna-rss/issues/877
Fixes a bug introduced in 67d181764be6d9f242392e689ad38aea6d533796
-[RichXMLParser init] called [self setTitle:@""]. When the -init method was deleted, the title was no longer guaranteed to be non-nil.
commit f6766b33ea380f963829785d00f3b3c230ea70e7
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Sat Aug 26 15:36:55 2017 -0500
Restore truncation that was removed in a6926eeee797b323b46e971d364f29f1de42bc52
Setting tighteningFactorForTruncation to 0.0 stops the text from being squeezed.
commit d54c2115e7b3281c93765a4b7bdeb4048b91240e
Author: Jeff Johnson <lapcat@users.noreply.github.com>
Date: Sat Aug 26 13:14:57 2017 -0500
Fix bug where Vienna doesn't quit when you press Quit Vienna in the Database Upgrade window.
commit cbaf15604664d1fb3f03e200f885f8cf7e56e1d7
Merge: 810fcf7f 84a02909
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Sep 3 07:38:56 2017 +0300
Merge pull request #976 from Eitot/file-quarantine
Enable File Quarantine
commit 810fcf7fbc0d0b5e918b7e94f0a864b6788cb134
Merge: a5a6bcd4 5e305722
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Aug 21 05:07:57 2017 +0300
Merge pull request #980 from Eitot/pods
Update Sparkle to 1.18.1
commit 5e30572221b04e5e3fbc5d126bfac99d71b280c6
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Aug 20 15:48:41 2017 +0200
Update Sparkle to 1.18.1
commit a5a6bcd43afd32aa90cc31925d6a51acb1820848
Merge: b31e3deb a180c4fe
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Aug 10 19:52:05 2017 +0300
Merge pull request #971 from barijaona/TypoFix
Fix typo on the word ‘inconvenience’
commit a180c4fef037f740fd3affda37750a17b337582a
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Fri Jul 28 11:32:11 2017 +0300
Fix typo on the word ‘inconvenience’
Almost the same thing than pull request #959 did:
- Sort Base Localizable.strings to reflect imports from Crowdin
- Comment it like `genstrings` does
- Add the last (‘Vienna must upgrade…’) item to work around the typo
commit b31e3deb848d382921d541c7c98040f2a5e169b5
Merge: 66c09fad b3348c0a
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Aug 10 19:45:08 2017 +0300
Merge pull request #977 from Eitot/swiftlint
Support SwiftLint 0.21
commit b3348c0ab248502cfa395d3fce4cf844e0bf742e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Aug 6 13:00:48 2017 +0200
Update Swift code to comply with SwiftLint 0.21
commit e7f6f6f3e08ec50fd57c0abb71b7d5d724c11a95
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Aug 6 12:53:48 2017 +0200
Update .swiftlint.yml for version 0.21
commit 84a029090e8bf88056aeefe3bee79b8cf0903f3d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Aug 6 11:08:26 2017 +0200
Enable File Quarantine
commit 66c09fadfcc1d2d830616e4fc4a521f81023268f
Merge: e961b3de fe4c63ae
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Mon Jul 31 16:53:09 2017 +1000
Merge pull request #974 from Eitot/pods
Update Sparkle to 1.18.0
commit e961b3dec51ccdf0a4300d4cd5059de20a6b6faf
Merge: f248af4d c1672b99
Author: Josh <799345+josh64x2@users.noreply.github.com>
Date: Mon Jul 31 16:47:53 2017 +1000
Merge pull request #973 from Eitot/open-link-fix
Use AppController singleton in TabbedWebView
commit fe4c63ae6910ec127c91225242613f2af8ae1253
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 30 17:27:09 2017 +0200
Update Sparkle to 1.18.0
commit c1672b993570443e9e6caae4929788feb065a16f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 30 14:00:30 2017 +0200
Use AppController singleton in TabbedWebView
ArticleListView is currently responsible for setting the controller property of its ArticleView child. This was done in -awakeFromNib, which was too early. The singleton is a more robust solution until the web view has its own controller.
commit f248af4d27055f4e2607af8df48049db6951efd6
Merge: ef2f2a8d 098d9fb4
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Fri Jul 28 12:14:56 2017 +0300
Merge pull request #970 from ViennaRSS/localizations
New Crowdin translations for Danish
commit 098d9fb4e5852e4529aebdf701e270be5c0a279d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 24 15:42:36 2017 +0200
Re-import localizations
commit 8bc10dab8c42db79bcac18fa18fbd25e91384f5b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 23 23:20:25 2017 +0200
New translations en.xliff (Danish)
commit ef2f2a8d58c23d26ff6c2bebc66127cbb1f52364
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 18:09:13 2017 +0200
New Crowdin translations (#968)
* New translations en.xliff
* Re-import localizations
commit 25d97c3d85ff04f03f024210e4a21db68ea8cc0b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 13:02:49 2017 +0200
New Crowdin translations (#967)
commit 502a609bb51b60ad925305d0e00f0057b1c3c24a
Merge: 94c7fa4d 519cf233
Author: Josh <josh64@gmail.com>
Date: Sat Jul 22 20:54:45 2017 +1000
Merge pull request #964 from Eitot/localisation-automation
Update localization script
commit 94c7fa4d087287920541fa9b5912136dfba9f70f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 12:04:32 2017 +0200
Update Crowdin configuration file
commit 519cf2332e862414bdb347d5dff563bae1feefa8
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 10:46:47 2017 +0200
Update localization script
commit 16f154b6d2115fbfb029d6e51a07fb768eceb8b5
Merge: 1427b49b 3ae3fe19
Author: Josh <josh64@gmail.com>
Date: Sat Jul 22 19:21:50 2017 +1000
Merge pull request #962 from Eitot/localisation-automation
Support automation of localisation import
commit 3ae3fe1900bc919f9c224229afbb3f72eeee3f3d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 10:46:47 2017 +0200
Add en.xliff file too
commit c958da912379960b20c3336830c602895006c6b4
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 22 01:01:30 2017 +0200
Update translations
commit 0c5fae4794a5ddb18e15d85482d5f8fb5f5c761b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 23:46:33 2017 +0200
Add latest XLIFF files
commit 1e25a45c2912c71636c8cb024eef8fc5b763b8d9
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 23:46:09 2017 +0200
Add new target for translation updates
commit 1427b49b5ef10609ca3267cbb630ab227dca05db
Author: Josh <josh64@gmail.com>
Date: Sat Jul 22 18:11:23 2017 +1000
Update Crowdin configuration file
commit 37658a28714421db8239de94398c5d4f107dccf3
Merge: 15baf597 31831fcf
Author: Josh <josh64@gmail.com>
Date: Sat Jul 22 07:00:26 2017 +1000
Merge pull request #958 from Eitot/localised-strings
Move some localizable strings to IB
commit 15baf597097fced36ed193ebf675bb3debdc91a1
Merge: a9dd5083 a9577beb
Author: Josh <josh64@gmail.com>
Date: Sat Jul 22 06:59:47 2017 +1000
Merge pull request #957 from Eitot/reimport-localisations
Re-import localisations
commit 31831fcf13ee71f7b57f7343ff3883a549090779
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 16:36:13 2017 +0200
Move some localizable strings to IB
commit a9577beb7caa5bfb76addd70f134633c8802ebe0
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 16:17:55 2017 +0200
Clean up English Localizable.strings file
commit 2a4abe2ffa8e5c9458ddbacb929bc89410e8d16c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 14:22:09 2017 +0200
Update localization section in the README file
commit f3376defb37da0b3d8746e1bc69d8a1dc9d64b82
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:26:27 2017 +0200
Re-import Chinese (traditional) translations
commit 198d9ea12aa775d3d05f6b8ce2cfd3fcf756e7cf
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:25:31 2017 +0200
Re-import Chinese (simplified) translations
commit 0005a0a3006b33ed67dab7aeb5e35f33bc9d0521
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:24:18 2017 +0200
Re-import Ukrainian translations
commit 5414df5b1340f6b03d5f60fcd6573708d101e917
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:23:24 2017 +0200
Re-import Turkish translations
commit e301654b48d13b7efc837fcb05324d7ebd26f79f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:22:35 2017 +0200
Re-import Swedish translations
commit 78f4c6a646b861f27f2b211e80995270a0a47b60
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:21:34 2017 +0200
Re-import Russian translations
commit 7c83e12a23e32ec621f993f30efa17a7e452ec31
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:19:37 2017 +0200
Re-import Brazilian translations
commit 01dfc39ab031305564f8bbf5c046afcdd26fbfd0
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:18:11 2017 +0200
Re-import Portuguese translations
commit d63ec16f069a407ab05cf48e9e23d6d684c845dc
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:16:46 2017 +0200
Re-import Dutch translations
commit 6030de3eb8ca1aa25aeb366c89b31c0baa1d261e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:13:40 2017 +0200
Re-import Korean translations
commit 869d577f5a01b14017b215b2fe09bf946abaa952
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:12:23 2017 +0200
Re-import Japanese translations
commit 493f6527005821c5d5b31516c363c403826121be
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:11:21 2017 +0200
Re-import Italian translations
commit 6e1d515f91cf0ae63a33c88b64a3174b945bdfe3
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:10:16 2017 +0200
Re-import Galician translations
commit fd5804eb514fa563dbc0dbd8f90c1f54467a19ba
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:08:52 2017 +0200
Re-import French translations
commit 68ff445fa738a6ee29408551895f002db761257f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:07:57 2017 +0200
Re-import Basque translations
commit 646e04da8a87cde0b1565fb80c5e610ca9901794
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:06:59 2017 +0200
Re-import Spanish translations
commit 2b9c9fa53f528f88bde3e9366eba2af0afc929de
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:04:38 2017 +0200
Re-import German translations
commit 0ef433b7e28c19fc399a704dbbde7d6df3b2eb41
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:03:25 2017 +0200
Re-import Danish translations
commit 73f2d85a2dea3033d0a3a6245701d8dd7e335e7d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 21 13:00:42 2017 +0200
Re-import Czech translations
commit a9dd50831ae6337c76fc64fd584678ea0a480b90
Merge: 483e670f deeebb20
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Fri Jul 21 04:25:52 2017 +0300
Merge pull request #953 from barijaona/translation5
Fix localization of field names in menus and in headers of article list
Transitional fix for smart folder localization and behavior
Closes issues #933 and #944
commit 483e670f8001d655de962a2c7d70296ddc95f4ac
Merge: 0d4d2241 e1dd2fb7
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Fri Jul 21 04:03:15 2017 +0300
Merge pull request #956 from Eitot/vienna-help-scheme
Remove Vienna Help scheme
commit deeebb20693b527560694f10e55a63fdb7414093
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jul 20 19:12:10 2017 +0300
Remove -operatorFromlocalisedString method
commit e1dd2fb720868e5e3356ede60b926b4db47b7461
Author: Eitot <Eitot@users.noreply.github.com>
Date: Thu Jul 20 12:55:22 2017 +0200
Remove Vienna Help scheme
This scheme is not used and does not need to be shared. A private one can be recreated as needed in Xcode.
commit 0d4d22415e1f9f4a3a480ab8c50ae37301aa14a5
Merge: 1f087df1 1ffeba72
Author: Josh <josh64@gmail.com>
Date: Thu Jul 20 19:23:41 2017 +1000
Merge pull request #952 from josh64x2/enable-travis-notifications
Added Travis Slack notifications
commit bc996a712a2dc461c8a0da83847778ebef19bc58
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jul 20 00:30:06 2017 +0300
Fix localization comments
commit 1ffeba72e0f3e5e8006fa6ac735a8d96a56d9455
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Jul 19 13:56:07 2017 +0200
Format Travis message for Slack
commit 5eaf4c3d011c40f141dc543ed8cb68ab00171097
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Jul 19 14:48:40 2017 +0300
Localization of display names of data fields
commit 915d1dddfb4f483f7126aed7d829e6e1baa521f5
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Jul 19 07:07:45 2017 +0300
Localization of criteria association conditions
commit 1dffdd8f2e093b900d63e4f6f04fb27b7ac646b3
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Jul 18 17:44:38 2017 +0300
Explicit localization of criteria test description
Limit use of NSLocalizedString with variables : part of solution to #933
commit 299960f733d9a4d4a671a0bc1c27d02d2d73af7b
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Jul 18 17:05:13 2017 +0300
Implement stricter control of criteria operators
Solves issue #944
commit 561c2432845c1862a7685a7c9d01e4c8c9e7f4ab
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Mon Jul 17 16:40:21 2017 +0300
Add/fix some localization help text
commit 1f087df195d6e7cb37f0aa18782b2832aa118066
Merge: 253eda93 ebb0a99b
Author: Josh <josh64@gmail.com>
Date: Wed Jul 19 17:57:56 2017 +1000
Merge pull request #949 from Eitot/localisations
Use NSLocalizedString with string literals
commit dadc7a3638fee9e6a4e07aaec5c025853bbe8f69
Author: Josh <josh64@gmail.com>
Date: Wed Jul 19 17:46:43 2017 +1000
Added slack notification setting
removed inactive webhook notification section
commit 253eda93918df086d444da32d6caf2685462c050
Merge: 0da1bec7 eb8e342b
Author: Josh <josh64@gmail.com>
Date: Wed Jul 19 17:38:42 2017 +1000
Merge pull request #950 from Eitot/linting
Add SwiftLint support
commit eb8e342b1b1ec7669eaed9370a28ee506c796180
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 16 21:11:05 2017 +0200
Add SwiftLint to Travis
Uses separate jobs that can be executed concurrently.
Also removes the unnecessary "xcode" and "sudo" keys.
commit 26866f3a56e8094f0ea392b50c0908ef9afe8a3c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 16 16:19:02 2017 +0200
Make the existing Swift code compliant with SwiftLint
commit 99ead5508c40d241c664fdacf06c011e3c85b2a6
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 16 16:14:32 2017 +0200
Add SwiftLint support
commit ebb0a99b21fa9b2f4500076ff45998371409491e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jul 18 15:01:36 2017 +0200
Remove -localiseHeaderStrings method
commit 340f042c70e85dd194f858ec21789fade9e81079
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jul 18 14:54:04 2017 +0200
Use keys of localized property-list files
KnownSyncServers.plist and RSSSources.plist are localizable files.
commit c14db96a8b99870fe0423dc1154eeeb00117f2e9
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jul 18 14:52:23 2017 +0200
Use NSLocalizedString for placholder strings in SearchMethod
commit 0da1bec7051d7949a0627f3d7d3411c031ed62f7
Merge: acc7e392 1e175584
Author: Josh <josh64@gmail.com>
Date: Tue Jul 18 17:08:35 2017 +1000
Merge pull request #948 from Eitot/sparkle-analytics
Remove Sparkle analytics and replace ViennaSparkleDelegate
commit acc7e3927f235ce6bb325ea8c4b7c0ef7821c22a
Merge: dd08df27 828130d9
Author: Josh <josh64@gmail.com>
Date: Tue Jul 18 17:04:23 2017 +1000
Merge pull request #945 from Eitot/toolbar-overflow-menu
Support toolbar overflow menu
commit dd08df276bce47dd8c66e1c87699391e80e11ec0
Merge: b40c530b 0e747e5b
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Jul 18 09:40:12 2017 +0300
Merge pull request #947 from Eitot/menu-item-validation
Fix a regression in menu-item validation
commit 0e747e5bd0083ab1b3a6e3ecf7bc91c8362730ca
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 17 22:31:42 2017 +0200
Fix a regression in menu-item validation
commit 1e1755845dc2c4ee0b363c8b2967fa38c964e55b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 17 23:33:10 2017 +0200
Replace ViennaSparkleDelegate with AppController category
No need for a separate object in memory. Setting the delegate itself can be done in IB.
commit 59ad2c2c52b9bc05d6e9c4a2691250d35e7930c6
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 17 23:03:53 2017 +0200
Remove Sparkle analytics
This is not currently used, thus the user should not be asked.
The localization strings can be restored, either from the log or from Crowdin.
commit b40c530b086ce500ca82906fa4aceabe19514efe
Merge: e4e83b83 ef499b8a
Author: Josh <josh64@gmail.com>
Date: Sun Jul 16 10:27:50 2017 +1000
Merge pull request #940 from Eitot/translation
Add strings files for two new XIB files
commit e4e83b8388727fbbb78e13ba27d754c78673d44b
Merge: b14ea647 69bd954b
Author: Josh <josh64@gmail.com>
Date: Sun Jul 16 10:26:27 2017 +1000
Merge pull request #941 from Eitot/enclosure-view
Fix Auto-Layout issue with StdEnclosureView
commit 69bd954b5bd63d83d99ab6e30705637aa2615b3e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jul 16 02:09:57 2017 +0200
Put EnclosureView subviews in stack views too
commit b14ea647a8af385e7393995880d4f312e3ac8fa4
Merge: b45b85dc fb2e5756
Author: Josh <josh64@gmail.com>
Date: Sun Jul 16 09:14:58 2017 +1000
Merge pull request #942 from Eitot/mark-all-items-as-read
Add toolbar item to mark all items as read
commit 828130d95fc1edc2acdc5cbeda8cce57183bb850
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 21:32:46 2017 +0200
Support toolbar overflow menu
commit b71ea53556b6f514617b99bef63bc4abf6af6171
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 16:38:25 2017 +0200
Rename StdEnclosureView to EnclosureView
commit fb2e57560ec885945848d867a11a881231a7a6b8
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 16:06:07 2017 +0200
Add toolbar item to mark all items as read
commit 6c6ec803c8237ea1715494f1816190f2b205336c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 15:31:33 2017 +0200
Fix Auto-Layout issue with StdEnclosureView
commit ef499b8ac088648f1776f83b593afdfdc9d28751
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 15 15:06:52 2017 +0200
Add strings files for two new XIB files
This will make sure that all translated strings are exported. The files are duplicates of MainMain.strings, but these will be cleaned up once XLIFF files are imported from Crowdin.
commit b45b85dc2910569357dcc7bbe4c9c371660c26e6
Merge: 096af2c9 3fb8d9dd
Author: Josh <josh64@gmail.com>
Date: Sat Jul 15 20:40:45 2017 +1000
Merge pull request #939 from Eitot/preferences-window
Fix Auto-Layout issue on combo box in appearance preferences
commit 096af2c9d508ccee0a51804d70c02919860e2eea
Merge: 484e3a38 7e3ded9d
Author: Josh <josh64@gmail.com>
Date: Sat Jul 15 18:48:15 2017 +1000
Merge pull request #930 from Eitot/window-controller
Refactor main window into separate window controller
commit 7e3ded9d7ebb9aea7a54aa59d2f2efacd202b07c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 14:22:00 2017 +0200
Move main window and all subviews to a separate XIB file
This moves the entire window and all other views into a new XIB file. MainMenu.xib now only serves the application, AppController and the main menu.
commit dcb72c324794b2ff0961fca64e943b9f5bac3f68
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 13:55:20 2017 +0200
Remove -copyOfMenuItemWithAction: method
This method creates a dependency on the main menu when called. Depending on where this gets called (e.g. -awakeFromNib), the main menu may not have been loaded yet.
commit 9dc4cbb1e80953d43b8c81307307d28633bde8ab
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 13:10:10 2017 +0200
Add workaround to populate both style menus
commit 0067b7cfe4794efc1ef946b6a818d458f012dafa
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 13:06:23 2017 +0200
Move ToolbarSearchField outlet to window controller
commit 463d87fa47b6b7650ff673c97436cf13c6d577c4
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 13:00:31 2017 +0200
Move FilterSearchField outlet to window controller
commit 61ed4db8dba6bc3b9ccd82b32979bd2e79b5c081
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:53:18 2017 +0200
Move FilterDisclosureView outlet to window controller
commit 09dedf845e39ebb1b4104a21c629508de7786f9d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:46:57 2017 +0200
Move OutlineView outlet to window controller
commit 95e8cc0956b34e9a99cbbe1f4fa907c92ae271e0
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:42:33 2017 +0200
Move BrowserView outlet to window controller
commit 883d1ed930b4b5fa34c5a6ebcd4e2e1eb26cb605
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:34:25 2017 +0200
Move ArticleListView and UnifiedDisplayView outlets to window controller
commit 709727e75ada8c403a22bed150bacee74db29f1f
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:25:23 2017 +0200
Make AppController ivar on UnifiedDisplayView a property
commit 0f005551cacb01ef7e8607b93711474398573fa5
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 12:22:44 2017 +0200
Make AppController ivar on ArticleListView a property
commit 953d1636e83c42881ae7d40dc57e121151a3275c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 00:04:50 2017 +0200
Remove IBOutlet declaration from ActivityPanelController property
commit 95040798a295a50a5ad5488f3d3eb7faa46e3d89
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 7 20:39:06 2017 +0200
Redirect other controls to first responder
commit 7b304eea4f391f2e370864a48233cbe81d758d1e
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Jul 5 18:28:44 2017 +0200
Redirect main-menu actions to first responder
commit a2d4746b8632ec215eb0c52ebceeca9cdc5f67cb
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 1 11:43:10 2017 +0200
Add new toolbar icons
commit a6b350414f069bc26bab00483963512892d9dc08
Author: Eitot <Eitot@users.noreply.github.com>
Date: Thu Jun 29 15:55:07 2017 +0200
Remove BJRWindowWithToolbar class
This was a clever solution, but unfortunately not usable for all translations, as Apple does not provide strings files for each language Vienna currently supports.
commit 650cdfb2b666d5a9b255c57d16d71f1761ae68c2
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Jun 28 23:10:05 2017 +0200
Remove unused NSMenuDelegate conformance from AppController
commit 5761c39a6a49194a49c3ce73395d166c63513bc3
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Jun 28 20:30:07 2017 +0200
Delete unused toolbar icons
commit 6dad05b4b34bd12ed61e6e0235fb0ea85203b9fc
Author: Eitot <Eitot@users.noreply.github.com>
Date: Wed Jun 28 13:34:56 2017 +0200
Replace ToolbarItem and ToolbarButton classes
The previous implementation was based completely on images. This new implementation uses NSButton. As a result, the custom code is no longer required. Custom behaviour, such as generating smaller or grayed-out images is no longer needed either.
In most instances, it is enough to refer to NSToolbarItem instead of a subclass.
commit 8b64a3b8015b8756eed6ea79bc3b28cfbe537d3c
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jun 26 21:19:23 2017 +0200
Remove unused PopupButton class and reduce ToolbarItem class
commit 6fd8c2420a1e899617feb270c1e46582ee8504fa
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jun 26 20:27:12 2017 +0200
Remove unused -toggleOptionKeyButtonStates: method
The toolbar item is now a pop-up button.
commit 8528c095d9ba68dfa2735ef3b61c71f6943a1c3d
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 18:26:46 2017 +0200
Move folderMenu property to FoldersTree
commit b6c4d5b94dd104458040e6e857b363d6b8f8aa79
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 16:57:13 2017 +0200
Add workaround to populate plug-ins menu
The previous method had a direct dependence on the main menu and would fail, as the menu had not been loaded at this point. This is because the plugin manager is now initialized before the UI is loaded.
commit 37e1dd9af3ffad09aa5c8536055e8b79e26589fe
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 14:18:05 2017 +0200
Move toolbar to IB and its delegate into the window controller
The plug-in menu items are disabled for now, as they cause an issue with the initialization order.
commit 6e0c690550f2bd59e72cc4a9ba0bb8992414ba90
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 14:13:51 2017 +0200
Remove spinner toolbar item (for now)
This is causing some weird problems with the initialization of the toolbar.
commit b2d7582dbc74c7d0b67ef1bd0c04a771319f2f35
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 12:24:58 2017 +0200
Move status-bar disclosure view to window controller
commit 77831a36d7af9e13591644aaa4364f1808ce6dea
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 06:06:27 2017 +0200
Refactor filterMode preference with KVO pattern
commit 2ba92cdeeb9d76b240eb6df332bf046275c73c4b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sun Jun 25 05:56:17 2017 +0200
Refactor filter label and filter menu
Merges the ArticleFilter class into ArticleController. The filter menus are now initialized in Interface Builder. The item selection happens via Cocoa bindings.
The menu-item target is the first responder. Temporarily, this role will be fulfilled by the window controller until Article Controller becomes a view controller.
The filter menu in the main menu is referenced with a property in ViennaApp. This place is preferred, because the main menu is also there. This allows the status bar to access it.
commit e2aff6a617c81602f7f637f360dad3670873210a
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jun 19 20:26:29 2017 +0200
Refactor the status bar with KVO pattern
OpenReader and RefreshManager obtain a new property though which they can set their status. The new window controller will observe these properties and change the status message accordingly.
commit 3fb8d9dd2037a4626b56ba66af99133dc1c3cabc
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 14 13:29:20 2017 +0200
Fix Auto-Layout issue on combo box in appearance preferences
commit a4c220fd479ec1259c2d189477e75795f1551753
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jun 19 20:04:27 2017 +0200
Add MainWindowController class and use it for the main window
Also replace the mainWindow ivar with a private property.
commit 484e3a3859ff49cfaa03856ac8e99306aa55c222
Merge: c6342aa9 1dc91373
Author: Josh <josh64@gmail.com>
Date: Fri Jul 14 06:42:03 2017 +1000
Merge pull request #936 from Eitot/statusbar
Add OverlayStatusBar class
commit 1dc913736e3e1a5d6c7022e58868ec1fca85cac4
Author: Eitot <Eitot@users.noreply.github.com>
Date: Thu Jul 13 18:32:00 2017 +0200
Implement KVO for status-bar preference
commit 9bfe4c4666976a66b8db1efd26015de9222165fc
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 10 20:55:06 2017 +0200
Implement the status bar
commit 3039c48436f2dad9b32a0e1fafd97a63156cd945
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 10 20:24:08 2017 +0200
Add OverlayStatusBar class
This replaces one part of the status-bar functionality, specifically showing link destinations.
The class is modelled after Safari 9 and later.
commit 726fea7073add7a65016226251ba7ece9af6a1d0
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 10 01:58:20 2017 +0200
Remove status message for frame loading in web views
This kind of of progress indication should be presented differently. The user might want to know this without having to enable the status bar.
commit 354b350d5b8ccd9fe0ef7830948a6dac1e8a1a60
Author: Eitot <Eitot@users.noreply.github.com>
Date: Mon Jul 10 01:32:09 2017 +0200
Remove -webview:setStatusText: method from web-view delegates
The underlying functionality is effectively obsolete in modern browsers; JavaScript writes to window.status are simply ignored in favour of showing URLs and other context-specific information. Dropping this will make it easier to replace the current status-bar functionality.
commit c6342aa955a8e106e1a6dcb7b03700259eff1a6e
Merge: cf9336e9 24d52773
Author: Josh <josh64@gmail.com>
Date: Tue Jul 11 09:24:34 2017 +1000
Merge pull request #935 from Eitot/availability-error
Address an availability issue on 10.9
commit cf9336e953d2a7f4c02ba8f9540748b147148b42
Merge: cbdd3725 53e8fca8
Author: Josh <josh64@gmail.com>
Date: Tue Jul 11 09:23:57 2017 +1000
Merge pull request #932 from Eitot/export-accessory-view-controller
Move ExportSaveAccessory into own view controller and XIB file
commit 24d52773d7fe3b69b86ce6a4aaf63a5e0b219660
Author: Eitot <Eitot@users.noreply.github.com>
Date: Sat Jul 8 10:24:21 2017 +0200
Address an availability issue on 10.9
commit 53e8fca883ee512a6a14ce7998d1f745668a4736
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 7 21:50:10 2017 +0200
Move ExportSaveAccessory into own view controller and XIB file
commit cbdd37254a1b634db73341b38e6596119547606e
Merge: c42afb98 f52892e4
Author: Josh <josh64@gmail.com>
Date: Sat Jul 8 09:22:04 2017 +1000
Merge pull request #931 from Eitot/article-controller
Remove ArticleController and FoldersTree from Interface Builder
commit f52892e4a3ed66fd5f650bdaca35e3af5be254e8
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 7 14:15:25 2017 +0200
Turn FoldersTree into NSObject instead of NSView
commit 129bd30102b6630cbdf9ff4bb3cc8a499b903523
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 7 13:36:02 2017 +0200
Remove FoldersTree object from MainMenu.xib
FoldersTree is now created in AppController instead of IB. FoldersTree's outlet to the outline view is replaced with a property. The outline view itself is now an outlet on AppController, which AppController will pass to FoldersTree. The outline view's outlets are also set by AppController.
The initialization happens at the -applicationDidFinishLaunching: stage in AppController. This leaves -awakeFromNib with AppController-specific setup.
commit c194072d5059b6ff1031f5bb7e62e776062a9bf7
Author: Eitot <Eitot@users.noreply.github.com>
Date: Fri Jul 7 13:33:19 2017 +0200
Move some code from -awakeFromNib to -applicationDidFinishLaunching:
commit d9ea47928b19f14604f5e7eb077a09e219964c69
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 11:42:46 2017 +1000
Fixed article selection for ArticleController
FoldersTree was not connected and so the current selected article could not be read.
Removed IBOutlet from the properties because we are no longer in Interface Builder
commit 95941cf608fcafa3e32739972ffea9e3b51986fe
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 10:25:14 2017 +1000
Removed ArticleController from MainMenu.xib
- Instantiate lazily in AppController
- AppController 'owns' articleController
- AppController has weak references to Unified/Article views
- AppController gives articleController ownership of these views
commit 4e6df960b07d6fdc3282552ada49403a3c01a7df
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 10:24:08 2017 +1000
ArticleController has ownership over its views
Changed from weak properties to strong
commit eba82420d02564bec12e81d355cb11e6b1efdeec
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 10:22:54 2017 +1000
Use AppController's articleController directly
Removed our instance variable for articleController
commit c463774f80d6ad82a49e109d39daa96ca28ccf11
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 09:27:51 2017 +1000
Converted article/unified ListView to properties
commit a50d92508809afa2cd035bad23b8f29ab8cf8da0
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 09:18:49 2017 +1000
reconnected articleController outlet to AppController
commit 4410272179441148aa7658a5a3fbe7bd113da9a2
Author: Josh <josh64@gmail.com>
Date: Fri Jul 7 09:14:57 2017 +1000
Converted articleController ivar to property
commit c42afb98159cfa559dccddefb3807951e63ae117
Merge: 8496d5cf ed45096c
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Wed Jun 28 13:12:37 2017 +0300
Merge pull request #927 from barijaona/bugfixes
Handle when current folder does not contain any unread article and
no article is selected.
commit ed45096cd535fe71d298ff2b0bef8d77bfef72ab
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Tue Jun 27 00:32:54 2017 +0300
Fix ‘Next Unread’ command (continued)
Handle when current folder does not contain any unread article and
no article is selected.
commit 8496d5cffd6c07446ddff25a4e4fb8f2c4b122b4
Merge: d25927c1 952b683a
Author: Josh <josh64@gmail.com>
Date: Sun Jun 25 18:20:49 2017 +1000
Merge pull request #925 from barijaona/bugfixes
ArticleController related bug fixes
commit 952b683aabc9d2595acf56e0c7a1a2b73aeb385a
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jun 25 10:49:09 2017 +0300
Remove unused variables
commit b4dac1f879bafbcd5677ddacbaf14d73a735108f
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jun 25 09:58:29 2017 +0300
Fix selection of last unread article
Issue #904 : when there is only one unread article left and it's not in
the current folder selection, the 'next unread' command did not work.
commit 9821725debd8944d94d78732310370ece84b3d18
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jun 25 09:52:59 2017 +0300
Make sure the database updates the "deleted" flag
When the user marks an article deleted, ArticleController also attempts
to mark it read and un-flagged.
On articles from an OpenReader feed, the effect is not immediate,
so the database failed to update the "deleted" flag.
We force it to do so.
commit 97b5d94edcdbf32869c84a0ffcc284b628b6172e
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sun Jun 25 09:38:09 2017 +0300
Review management of current article selection
In order to fix more easily issue #924, we simplify the management of
the article whose display we want to preserve on updates.
May help on issue #601 too.
commit d25927c1bb455349cc1df2e222120fd7f7fad5e2
Merge: 07505846 0e8937b2
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 21:45:32 2017 +1000
Merge pull request #923 from barijaona/bugfixes
Fix missing article’s body after commit e49d8ac
commit 0e8937b2c3a2d3ee4dd664715bd8740b7665fc71
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jun 24 14:23:49 2017 +0300
Fix missing article’s body after commit e49d8ac
commit 0750584653018b30c29180f4377e417d8e721f88
Merge: 214eb040 c1a1f7b5
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Sat Jun 24 08:35:03 2017 +0300
Merge pull request #922 from josh64x2/code-cleanup
Code cleanup
commit c1a1f7b5955a7c163bbe0d8941d175f49ddf113e
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 15:20:14 2017 +1000
Revert "Changed SafeString from macro to extern method"
This reverts commit b12c56a87b121c6e595d65df0595f11272ed22a2.
Requested by @barijaona
commit b12c56a87b121c6e595d65df0595f11272ed22a2
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 10:59:32 2017 +1000
Changed SafeString from macro to extern method
commit affa6b6c2fa45f65dcd4bfee9ce1ed782b2c4545
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 10:44:05 2017 +1000
Converted Article Field IDs to NS_ENUM
Improves Swift compatibility and compiler warnings
commit 7cbb3a0843b8950830a7f8610a808f14f1119e28
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 09:29:58 2017 +1000
Converted enum to new style NS_ENUM
commit e49d8ac538f33df7b785798b97816e90424fc5e5
Author: Josh <josh64@gmail.com>
Date: Sat Jun 24 09:26:09 2017 +1000
Removed separate instance variables from FeedItem
- Use the standard properties ivars instead of our own
- changed init method to use standard format
- Renamed description property because it's a reserved word
commit 214eb040a86fc9cc6c43bb37572adc24055540b1
Merge: 15e8726c 71c53ab7
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jun 22 08:11:50 2017 +0300
Merge pull request #920 from josh64x2/google-reader-refactor
Rename GoogleReader to OpenReader and some small changes
commit 71c53ab759ed1ae798046a395a681239157f384c
Merge: 5a8891f3 ee9ea387
Author: Josh <josh64@gmail.com>
Date: Thu Jun 22 12:33:45 2017 +1000
Merge pull request #26 from barijaona/google-reader-refactor
Style OpenReader
commit ee9ea38792c9cd880fa07a02ff8b3b4c5a3a4730
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jun 22 05:23:02 2017 +0300
Enforce our guidelines for indentation / spacing
commit e75dcfd3d8627ddb9b9859aa0b2a062728e50645
Author: Barijaona Ramaholimihaso <github.com@barijaona.com>
Date: Thu Jun 22 04:49:27 2017 +0300
Use dot notation for currentTimestamp call
commit 5a8891f322ef49b330269df50a3b73e55db0b2ab
Author: Josh <josh64@gmail.com>
Date: Wed Jun 21 21:12:51 2017 +1000
use dot notation for NSDate call
commit 5d2da206ea4ed17260a0f60e196171eccf53fb4d
Author: Josh <josh64@gmail.com>
Date: Wed Jun 21 18:14:12 2017 +1000
Changed TIMESTAMP from macro to class method
commit 562e96e9ccc6d91138318ad3ffd8a6142a50e18e
Author: Josh <josh64@gmail.com>
Date: Wed Jun 21 18:06:53 2017 +1000
Converted enum to modern style
Also did some more renaming
commit 3e6e4581ac63db58b030b1387082236a32589e97
Author: Josh <josh64@gmail.com>
Date: Wed Jun 21 17:57:19 2017 +1000
Renamed GoogleReader to OpenReader
GoogleReader was the original name but has been defunct for a few years now.
commit 15e8726cb26fa7e0a1e08d03077237056485325b
Merge: dd4e0d7f 4fed2634
Author: Josh <josh64@gmail.com>
Date: Wed Jun 21 17:40:18 2017 +1000
Merge pull request #919 from Eitot/info-panel
Adopt delegate pattern in InfoPanelController
commit 4fed2634a64770fa095fd054345cb23b8229a092
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jun 20 23:30:43 2017 +0200
Make some changes to ActivityPanelController
Use the same nomenclature and coding style, and make the delegate
property weak.
commit c0ccc8f230d9e78fdf850b8ca1b6eef32ee303f0
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jun 20 23:26:23 2017 +0200
Refactor InfoPanelController to use the delegate pattern
commit f13506ce1a87a43ba0df4722b0987a361bd0b95b
Author: Eitot <Eitot@users.noreply.github.com>
Date: Tue Jun 20 15:46:59 2017 +0200
Rename InfoWindow, split into separate files and modernize it
Thi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1052 by changing all image asset images to have direction of "Fixed"