Use a NSCache for storing folder's articles #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganized handling of unread count in Database manager - Creation of articles is performed through the Folder class (this contributes to recenter cache management in Folder class and makes the code more legible) - Cleanup in Database manager source
- NSCache has no enumerator, so we must setup our own management in order to provide the unread articles - The keys are stored in a NSMutableOrderedSet (which guarantees its elements are distinct, contrary to an NSMutableArray) - Contrary to NSMutableDirectory, NSCache does not store keys ; so it seems important that keys are always stored __before__ objects are written to cache - Fixed an important comment about Database’s arrayOfArticles - It seems more coherent that Database’s methods are accessed through folder Id rather than through the Folder object
Note the precautions to avoid conflicts between threads who would lead the cache to be accessed in an unstable state. I don’t realize the conditions which may lead to execution of lines 736 to 739 of Folder.m But I saw these conditions arise on my earlier tests, at least after a feed refresh was performed under severe memory stress (achieved with a `memory_pressure -l critical` command)
Group folders and smart folders do not guarantee that all articles will have distinct GUIDs
Some folders were marked as cached, while their cacheGuids were empty. It appears that under heavy memory pressure, NSCache’s -setObject:forKey might immediately release the key. A workaround is copying the key into a distinct object. I also reverted cachedGuids to be a NSMutableArray, for the sake of simplicity.
josh64x2
added a commit
that referenced
this pull request
Sep 13, 2015
Use a NSCache for storing folder's articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.