Extract template compiler from base #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeWilliams
force-pushed
the
bmw/compiler
branch
from
532e2ca to
dda1665
Compare
BlakeWilliams
commented
Oct 16, 2020
|
|
||
| attr_reader :component_class | ||
|
|
||
| def define_render_template_for |
Contributor
Author
There was a problem hiding this comment.
I think this might be the only introduction of new code here, but this gives us a small performance boost by letting us avoid having to call send to render the correct template in the component.
joelhawksley
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This extracts the template compiling logic from the base class to help reduce
ViewComponent::Bases public API. This should hopefully make it easier tomodify the template compilation logic by separating it from the base class
logic.
Other Information
There may be a breaking change or two hidden in this PR, such as
ViewComponent::Baseno longer havingvariantsdefined on it. I don't thinkthat many components would have relied on that method being callable, but worth
discussing if it should be supported.