From 3f6fd996e3ebc2542a0d0947440bea424e63624d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mikael=20Lepist=C3=B6?= Date: Thu, 20 Apr 2017 21:47:27 +0300 Subject: [PATCH] Made error message more clear when .customResponse() is used wrong --- route/router/Route.js | 2 +- route/tests/Router.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/route/router/Route.js b/route/router/Route.js index aa1dd52..3b4c042 100644 --- a/route/router/Route.js +++ b/route/router/Route.js @@ -148,7 +148,7 @@ Route.prototype.handlerMiddleware_ = function (req, res, next) { return promise.then(function (result) { if (result === NO_RESULT) { if (!res.headersSent) { - throw new Error("Handler function did not return promise which won't resolve until response has been sent. " + + throw new Error("When using .customResponse() handler, the promise returned must not resolve before the response has been sent. " + "Requested path: " + req.path); } return; diff --git a/route/tests/Router.spec.js b/route/tests/Router.spec.js index cf882de..f915c68 100644 --- a/route/tests/Router.spec.js +++ b/route/tests/Router.spec.js @@ -574,7 +574,7 @@ describe('Router', function () { }); var nextSpy = spy(function (err) { - expect(err.message).to.contain('Handler function did not return promise'); + expect(err.message).to.contain('When using .customResponse() handler, the promise returned must not resolve before'); }); return mockExpressRouter.simulateRequest(request, response, nextSpy)