Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Laravel 5.6 #279

Merged
merged 6 commits into from Mar 13, 2018
Merged

Support for Laravel 5.6 #279

merged 6 commits into from Mar 13, 2018

Conversation

holix
Copy link

@holix holix commented Mar 1, 2018 •
edited

Hi,
this PR is to add support for Laravel 5.6.
It breaks compatibility with older versions of Laravel.

michaelcontento
michaelcontento suggested changes Mar 2, 2018
View reviewed changes
Copy link

@michaelcontento michaelcontento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using your branch I ran into:

Class Vinelab\NeoEloquent\Migrations\DatabaseMigrationRepository contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Database\Migrations\MigrationRepositoryInterface::getMigrationBatches)

@holix
Copy link
Author

holix commented Mar 2, 2018

@michaelcontento
I've implemented getMigrationBatches method, and added neo4j:migrate:status command

@michaelcontento
Copy link

@holix Cool, thanks! Works on my side perfectly 👍

@Mulkave
Copy link
Member

Mulkave commented Mar 7, 2018

This is awesome!

How can we provide this without breaking compatibility? Maybe merge on a different branch? If so, let me know so that i create that branch and merge accordingly.

@holix
Copy link
Author

holix commented Mar 7, 2018

I think that we should go with different branch.

@Mulkave
Copy link
Member

Mulkave commented Mar 13, 2018

Since we're following the releases pattern, where the same branch (1.4) contains the latest and support is specified by release as mentioned in the docs. So this will be 1.4.6+

@Mulkave Mulkave merged commit fe53a22 into Vinelab:1.4 Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcontento michaelcontento michaelcontento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holix @michaelcontento @Mulkave