proposed fixes and enhancements

[luckman212]

hey @Vinzent03 👋

thanks for your awesome plugin!

I had a problem and made this patch. It fixes the case that caused the plugin to fail when core Templates plugin is disabled but you still have @SilentVoid13's Templater enabled.

summary:

• fixes a case when core Templates plugin is disabled but @SilentVoid13's Templater is enabled
• I believe I fixed a problem that caused plugin settings not to be saved when flipping the toggles on/off
• some changes to make it easier to add support for other Template plugins in the future
• and a few other little tweaks in there, a bit of logging, added notice to settings panel if no template plugin is enabled in case user misses the Notice popup

Tested against Obsidian 0.11.13, macOS
Hope this is ok.

[Vinzent03]

Thanks for your contribution. I had the problem with the disabled core plugin in mind, but I must have forgotten it to fix.
In addition to my comments I want to mention, that the activated plugins are only registered on onLoad(). When the plugin is already loaded and the user activates for example Templater, he cannot see the templates to activate.

[luckman212]

@Vinzent03 thanks for reviewing. I see your point about the renames causing the existing hotkeys to need to be re-entered. I'll revert that, but maybe some sort of migrateSettings() function could be created that reads in the old keys and updates them to the new name? Maybe for v1.2.0.

As for dynamically rebuilding the list upon loading/unloading the plugins, that's a nice idea but I don't think there's a hook to register for plugin load/unload events? I looked at the current API and could not find one.

I asked on Discord and posted to the Obsidian forum as well.

[Vinzent03]

I don't thing the need to change those names is that high that a migration is worth it.

I would just re-recognize the activated plugins in PluginSettingTab.display()

[luckman212]

ok @Vinzent03 I split out the enumeration to a separate function so it dynamically loads/updates when plugins are toggled on/off. Didn't even think that was possible but—it works! I would still like your second opinion.

2 specific things I am unsure about:

1. should this enumerateTemplates() function be async/await? I'm not familiar enough with that to know for sure.
2. do we need to remove all commands first before re-enumerating and pushing them back into the stack? E.g. if no plugins are toggled on/off but Settings pane is just opened/closed a bunch of times, are duplicate commands being added by addCommand(). Again, not sure and would love your feedback.

[Vinzent03]

should this enumerateTemplates() function be async/await? I'm not familiar enough with that to know for sure.

No it does not have to be, because there happens nothing async.

do we need to remove all commands first before re-enumerating and pushing them back into the stack? E.g. if no plugins are toggled on/off but Settings pane is just opened/closed a bunch of times, are duplicate commands being added by addCommand(). Again, not sure and would love your feedback.

In my experience that was not a problem. I guess they are overwriting the existing one because of the id.

[luckman212]

@Vinzent03 The answer to your questions above is mostly "because the compiler told me to" 😛
but I will double-check now to see if I can tighten these up.

[Vinzent03]

Looks great! Thanks again for fixing this and cleaning up the code. It was not the best before, because of the adding of the Templater plugin.