Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added checking for null before working with property values #296

Merged
merged 2 commits into from Dec 3, 2019
Merged

Added checking for null before working with property values #296

merged 2 commits into from Dec 3, 2019

Conversation

pushnitsa
Copy link
Contributor

Issue comes when we try to create item in the IItemService.Create() with object which have PropertyValues = null.
Dear colleagues, could you please tell me, why we do not initializing collections in the constructors?

@yecli
Copy link
Contributor

yecli commented Dec 3, 2019

Dear colleagues, could you please tell me, why we do not initializing collections in the constructors?

If you meant initializing this collection Product.PropertyValues in the model - probably because we want this null value to be the marker that collection should not be changed in entity.

@yecli yecli merged commit 606b133 into dev Dec 3, 2019
@yecli yecli deleted the property-values-null-refference-exception-fix branch December 3, 2019 12:52
@yecli
Copy link
Contributor

yecli commented Dec 4, 2019

Released in https://github.com/VirtoCommerce/vc-module-catalog/releases/tag/v2.23.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatarincev tatarincev tatarincev approved these changes

@yecli yecli yecli approved these changes

@kostyrin kostyrin Awaiting requested review from kostyrin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pushnitsa @yecli @tatarincev