Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add November 2023 Challenge #1077

Merged
merged 20 commits into from Nov 2, 2023

Conversation

adiati98
Copy link
Sponsor Contributor

@adiati98 adiati98 commented Oct 29, 2023

Linked Issue

Closes #1074

Description

This PR adds November challenge onto the webpage with details as follow:

  • Added nov-2023.tsx --> copied and updated from app/routes/__frontend/monthlychallenges/nov-2022.tsx.
  • Updated monthlychallenges/index.tsx with current challenge.
  • Updated data/monthlyChallenges/getChallenges.ts.
  • Added the alert of challenge is complete in app/routes/__frontend/monthlychallenges/oct-2023.tsx

Live Preview

Monthly Challenge Page:
https://deploy-preview-1077--virtual-coffee-io.netlify.app/monthlychallenges

November Challenge Page:
https://deploy-preview-1077--virtual-coffee-io.netlify.app/monthlychallenges/nov-2023

October Challenge Page:
https://deploy-preview-1077--virtual-coffee-io.netlify.app/monthlychallenges/oct-2023

Methodology

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@adiati98 adiati98 requested a review from a team as a code owner October 29, 2023 15:00
@netlify
Copy link

netlify bot commented Oct 29, 2023

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit 046f2b5
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/6542816311893100089ce6ab

@adiati98
Copy link
Sponsor Contributor Author

adiati98 commented Oct 29, 2023

@danieltott I've copied the nov-2022.tsx and added nov-2023.tsx.
I get yelled a lot by TypeScript and I also don't have an API keys, so I can't check it out locally.

I updated everything as much as I can based on last year's files and previous PR.
I need your help with this as I'm not familiar yet with CMS. I also commented out the codeblocks that required API.

This PR is still waiting for the blogpost.

Please let me know if I need to fix anything and/or make this PR ready for review. TIA 😄

@adiati98 adiati98 marked this pull request as draft October 29, 2023 15:02
@adiati98 adiati98 marked this pull request as ready for review October 29, 2023 16:29
@BekahHW
Copy link
Member

BekahHW commented Oct 30, 2023

This looks good to me. We can merge this in after @danieltott makes the form updates.

@danieltott what do you think about putting the link to the form on the page? We can specify that it's for members only and delete any entries that aren't from VC members if that happens to be an issue. I'm just trying to think of what we can do to make it easy for members to find.

@danieltott
Copy link
Member

Since last year, we're embracing an official topic as well as general topics. We added a Developer Health section to our site. We'd love to feature our members' blog posts on the topic.

@adiati98 @BekahHW this is the same theme and copy from last year - are we sticking with that? It's fine if so, I just wanted to confirm.

@danieltott
Copy link
Member

I updated the code to read from airtable this year. Here's the Deploy preview with some fake data: https://deploy-preview-1077--virtual-coffee-io.netlify.app/monthlychallenges/nov-2023

The airtable form is linked in the post, here it is for previewing: https://airtable.com/app10kd5ewHiLTjxn/shrgRjUFpNjLN1V12

@danieltott
Copy link
Member

For context, the entire "Current status" list and table will be hidden when there are no entries, and will show up as soon as someone posts something. But let's make sure to delete those dummy entries before we merge this 😂

@adiati98
Copy link
Sponsor Contributor Author

Since last year, we're embracing an official topic as well as general topics. We added a Developer Health section to our site. We'd love to feature our members' blog posts on the topic.

@adiati98 @BekahHW this is the same theme and copy from last year - are we sticking with that? It's fine if so, I just wanted to confirm.

Yes, I only changed the wordings in the beginning from "This year" to "Since last year" because I'm not sure if we want to use it or not. 😁

As for me, we can omit it. Because we have a bunch of great writing ideas from last year that folks can get writing inspiration from on this page, @danieltott 😊
@BekahHW, any thoughts on this?

@adiati98
Copy link
Sponsor Contributor Author

@danieltott I've taken a look at the live previews.

Challenge page

The challenge page looks great! And I like that we can see the link to the add entry page. 🤩

Question: Should we log in to the add entry page later on?

Maybe make a clearer wording, too, for this part?

Once you've written and published your content, add your entry to our VC NaNoWriMo entry form!

Airtable form

In the Airtable form, there's an input for ShortDescription that is required. Would the description for the post be shown somewhere? If not, maybe we only need the title?

Note

Please don't delete the fake data. You're just too awesome! 😁

@danieltott
Copy link
Member

Question: Should we log in to the add entry page later on?

Maybe make a clearer wording, too, for this part?

@adiati98 I'm not sure what you're looking for here...

In the Airtable form, there's an input for ShortDescription that is required. Would the description for the post be shown somewhere? If not, maybe we only need the title?

That's a good question. We had it last year, but I don't know that we ever used it. @BekahHW what do you think?

@adiati98
Copy link
Sponsor Contributor Author

adiati98 commented Oct 31, 2023

@danieltott

Oh 😆
What I mean is this:

Maybe make this sentence in "How to Participate" section:

Once you've written and published your content, add your entry!

more clear like this? 👇

Once you've written and published your content, add your entry to our VC NaNoWriMo entry form!

@danieltott
Copy link
Member

@adiati98 updated 👍🏼

@adiati98
Copy link
Sponsor Contributor Author

Do we need to sign in to the entry page like previous years, @danieltott ?

@danieltott
Copy link
Member

Nope!

@BekahHW
Copy link
Member

BekahHW commented Nov 1, 2023

@danieltott I deleted those lorem ipsum fake entries in the files. Was I not supposed to do that?

@danieltott
Copy link
Member

Those are there for contributors that don't have the Airtable api key - if you could put them back that'd be good

@BekahHW
Copy link
Member

BekahHW commented Nov 1, 2023

@danieltott I think it's good to go

@BekahHW BekahHW merged commit e38c5b2 into Virtual-Coffee:main Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add November Monthly Challenge page with tracker.
3 participants