Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnChange works differently by the mouse and the keyboard #808

Closed
supasoft opened this issue Jun 26, 2018 · 4 comments
Closed

OnChange works differently by the mouse and the keyboard #808

supasoft opened this issue Jun 26, 2018 · 4 comments
Assignees
Milestone

Comments

@supasoft
Copy link

Changing the focus by the mouse:
1 call: Node is nil
2 call: Node is not nil (new focus)

Changing the focus by the keyboard:
1 call: Node is not nil (old focus)
2 call: Node is not nil (new focus)

@joachimmarder joachimmarder self-assigned this Jul 8, 2018
@joachimmarder joachimmarder added the Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. label Jul 8, 2018
@joachimmarder
Copy link
Contributor

The code that handles the left mouse button calls ClearSelection() if no multiselect should take place.

The code that handles the cursor keys calls RemoveFromSelection(FFocusedNode) if no multiselect should take place.

To make this consistent, we could call ClearSelection()in the keyboard case as well if no multiselection is required.

@supasoft
Copy link
Author

supasoft commented Jul 9, 2018

It is rigth. How to determine that the focus is removing from the node?

@joachimmarder
Copy link
Contributor

How to determine that the focus is removing from the node?

Have you tried the OnFocusChanging and the OnFocusChanged event?

@supasoft
Copy link
Author

I have not. Thank you.

@joachimmarder joachimmarder added this to the V7.1 milestone Jul 10, 2018
@joachimmarder joachimmarder added In Development and removed Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. labels Dec 17, 2018
joachimmarder added a commit that referenced this issue Dec 17, 2018
…keyboard induced chnage events compared to mouse events. Fixes issue #808
Sharlikran pushed a commit to ElminsterAU/Virtual-TreeView that referenced this issue Jan 17, 2019
…keyboard induced chnage events compared to mouse events. Fixes issue JAM-Software#808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants