Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set DEX string size #1073

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@CalebFenton
Copy link
Contributor

commented Jun 3, 2019

It looks like some code was copy / pasted and the wrong variables were changed for setting dex string sizes. The code now is using the string size as the index into the string table and the value its setting is the offset.

@CalebFenton

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

This was causing some really odd behaviors such as this rule failing:

rule somehow_fails {
    condition:
        dex.string_ids[0].size == 0x1
        or dex.string_ids[0].size != 0x1
        or dex.string_ids[0].size == dex.string_ids[0].size
}
@CalebFenton

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

The appveyor failure looks like it's for cygwin and it's complaining about a flex command being missing. I don't think it has to do with my change.

@plusvic

plusvic approved these changes Jun 3, 2019

@plusvic plusvic merged commit f0058e3 into VirusTotal:master Jun 10, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.