From b84c08f3dc6214568179daaeb9139cdc09680636 Mon Sep 17 00:00:00 2001 From: fangsmile <892739385@qq.com> Date: Thu, 4 Jul 2024 19:26:57 +0800 Subject: [PATCH 1/2] fix: disable select and edit input should move when input is outside of table #2039 --- packages/vtable/examples/editor/input-editor.ts | 8 ++++---- packages/vtable/src/state/select/update-position.ts | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/vtable/examples/editor/input-editor.ts b/packages/vtable/examples/editor/input-editor.ts index 09754094d..3413d2cad 100644 --- a/packages/vtable/examples/editor/input-editor.ts +++ b/packages/vtable/examples/editor/input-editor.ts @@ -171,10 +171,10 @@ export function createTable() { const instance = new ListTable(option); //设置表格数据 - // instance.setRecords(personsDataSource, { - // field: 'progress', - // order: 'desc' - // }); + instance.setRecords(personsDataSource, { + field: 'progress', + order: 'desc' + }); instance.on('change_cell_value', arg => { console.log(arg); diff --git a/packages/vtable/src/state/select/update-position.ts b/packages/vtable/src/state/select/update-position.ts index aa4ff9322..c662c2ecf 100644 --- a/packages/vtable/src/state/select/update-position.ts +++ b/packages/vtable/src/state/select/update-position.ts @@ -25,6 +25,9 @@ export function updateSelectPosition( const { highlightScope, disableHeader, cellPos } = state.select; if ((disableHeader && table.isHeader(col, row)) || highlightScope === 'none') { + if (col !== -1 && row !== -1 && !isSelectMoving) { + table._makeVisibleCell(col, row); + } col = -1; row = -1; } From 24adcc71164b55e9ac7567cc8a79cc53f79fa723 Mon Sep 17 00:00:00 2001 From: fangsmile <892739385@qq.com> Date: Thu, 4 Jul 2024 19:27:32 +0800 Subject: [PATCH 2/2] docs: update changlog of rush --- .../2039-bug-editInputPosition_2024-07-04-11-27.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@visactor/vtable/2039-bug-editInputPosition_2024-07-04-11-27.json diff --git a/common/changes/@visactor/vtable/2039-bug-editInputPosition_2024-07-04-11-27.json b/common/changes/@visactor/vtable/2039-bug-editInputPosition_2024-07-04-11-27.json new file mode 100644 index 000000000..72641726f --- /dev/null +++ b/common/changes/@visactor/vtable/2039-bug-editInputPosition_2024-07-04-11-27.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: disable select and edit input should move when input is outside of table #2039\n\n", + "type": "none", + "packageName": "@visactor/vtable" + } + ], + "packageName": "@visactor/vtable", + "email": "892739385@qq.com" +} \ No newline at end of file