From 02d918dfcf131db3c55edb199391536224df58af Mon Sep 17 00:00:00 2001 From: Rui-Sun Date: Tue, 25 Mar 2025 18:01:08 +0800 Subject: [PATCH 1/2] fix: disable group title editor --- .../fix-group-title-editor_2025-03-25-10-01.json | 10 ++++++++++ packages/vtable/examples/editor/date-editor.ts | 3 ++- packages/vtable/src/edit/edit-manager.ts | 7 +++++++ 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 common/changes/@visactor/vtable/fix-group-title-editor_2025-03-25-10-01.json diff --git a/common/changes/@visactor/vtable/fix-group-title-editor_2025-03-25-10-01.json b/common/changes/@visactor/vtable/fix-group-title-editor_2025-03-25-10-01.json new file mode 100644 index 0000000000..aecdd0a594 --- /dev/null +++ b/common/changes/@visactor/vtable/fix-group-title-editor_2025-03-25-10-01.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@visactor/vtable", + "comment": "fix: disable group title editor", + "type": "none" + } + ], + "packageName": "@visactor/vtable" +} \ No newline at end of file diff --git a/packages/vtable/examples/editor/date-editor.ts b/packages/vtable/examples/editor/date-editor.ts index f7561fd894..7f1456cbd4 100644 --- a/packages/vtable/examples/editor/date-editor.ts +++ b/packages/vtable/examples/editor/date-editor.ts @@ -184,7 +184,8 @@ export function createTable() { }, editor(args) { return new InputEditor({}); - } + }, + groupBy: ['sex'] }; const tableInstance = new VTable.ListTable(option); tableInstance.on('initialized', args => { diff --git a/packages/vtable/src/edit/edit-manager.ts b/packages/vtable/src/edit/edit-manager.ts index 04ac48e225..e1863894c5 100644 --- a/packages/vtable/src/edit/edit-manager.ts +++ b/packages/vtable/src/edit/edit-manager.ts @@ -90,6 +90,13 @@ export class EditManager { return; } + // group title cell do not allow edit + const record = this.table.getCellRawRecord(col, row); + if (record.vtableMerge) { + console.warn("VTable Warn: this is group title, can't be edited"); + return; + } + if (!this.editingEditor) { this.editCell = { col, row }; } From d479646d88c75aba84e5d9f6461ac479a8126273 Mon Sep 17 00:00:00 2001 From: Rui-Sun Date: Mon, 31 Mar 2025 20:21:22 +0800 Subject: [PATCH 2/2] fix: fix record undefined in startEditCell() --- packages/vtable/src/edit/edit-manager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vtable/src/edit/edit-manager.ts b/packages/vtable/src/edit/edit-manager.ts index e1863894c5..931287127f 100644 --- a/packages/vtable/src/edit/edit-manager.ts +++ b/packages/vtable/src/edit/edit-manager.ts @@ -92,7 +92,7 @@ export class EditManager { // group title cell do not allow edit const record = this.table.getCellRawRecord(col, row); - if (record.vtableMerge) { + if (record?.vtableMerge) { console.warn("VTable Warn: this is group title, can't be edited"); return; }