Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a looping indicator on modules #1217

Merged
merged 2 commits into from Mar 8, 2017
Merged

Add a looping indicator on modules #1217

merged 2 commits into from Mar 8, 2017

Conversation

remram44
Copy link
Member

@remram44 remram44 commented Mar 8, 2017

This indicates clearly that a module is looping (depth>0).

screenshot

Clicking on the icon opens the looping options.

@remram44
Copy link
Member Author

remram44 commented Mar 8, 2017

Lesson learned: the QPainter#drawXXX() methods that take numbers expect ints. In Python, passing floats will have them silently convert to integers. Pass QPointF explicitly to avoid rounding errors...

@remram44 remram44 merged commit 900a7b0 into v2.2 Mar 8, 2017
@remram44 remram44 deleted the module-loop-indicator branch March 8, 2017 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant