If branch not sent, take default branch #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suratdas
force-pushed
the
take-main-branch
branch
from
33d1dc3 to
3b261f3
Compare
pashidlos
requested changes
Dec 24, 2021
src/builds/builds.controller.ts
Outdated
| const build = await this.buildsService.findOrCreate({ | ||
| projectId: project.id, | ||
| branchName: createBuildDto.branchName, | ||
| branchName: (createBuildDto.branchName && createBuildDto.branchName.trim().length > 0) ? createBuildDto.branchName : project.mainBranchName, |
Member
There was a problem hiding this comment.
empty branch name should be validated in another place if needed
Suggested change
| branchName: (createBuildDto.branchName && createBuildDto.branchName.trim().length > 0) ? createBuildDto.branchName : project.mainBranchName, | |
| branchName: createBuildDto.branchName ?? project.mainBranchName, |
Member
There was a problem hiding this comment.
please, cover this with e2e test https://github.com/Visual-Regression-Tracker/backend/blob/master/test/builds.e2e-spec.ts
Collaborator
Author
There was a problem hiding this comment.
Thanks. Added. I also made branchName optional in the DTO just like ciBuildId.
Co-authored-by: Pavel Strunkin <pashidlos@gmail.com>
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable SDK and clients not to send branch information. That way, it will use the default branch if not provided.