diff --git a/src/test-runs/test-runs.service.spec.ts b/src/test-runs/test-runs.service.spec.ts index 76675774..3be46d25 100644 --- a/src/test-runs/test-runs.service.spec.ts +++ b/src/test-runs/test-runs.service.spec.ts @@ -414,9 +414,10 @@ describe('TestRunsService', () => { }); }); - it('calculate no diff', async () => { + it('recalculateDiff', async () => { const testRun = { id: 'id', + buildId: 'buildId', imageName: 'imageName', baselineName: 'baselineName', diffTollerancePercent: 12, @@ -443,6 +444,7 @@ describe('TestRunsService', () => { }); service.findOne = testRunFindOneMock; service.getDiff = getDiffMock; + service.emitUpdateBuildEvent = jest.fn(); await service.recalculateDiff(testRun.id); @@ -456,6 +458,7 @@ describe('TestRunsService', () => { testRun.diffTollerancePercent, testRun.ignoreAreas ); + expect(service.emitUpdateBuildEvent).toBeCalledWith(testRun.buildId); }); describe('saveDiffResult', () => { @@ -478,32 +481,32 @@ describe('TestRunsService', () => { }, }); }); - }); - - it('with results', async () => { - const diff: DiffResult = { - status: TestStatus.unresolved, - diffName: 'diff image name', - pixelMisMatchCount: 11, - diffPercent: 22, - isSameDimension: true, - }; - const id = 'some id'; - const testRunUpdateMock = jest.fn(); - service = await initService({ - testRunUpdateMock, - }); - - await service.saveDiffResult(id, diff); - expect(testRunUpdateMock).toHaveBeenCalledWith({ - where: { id }, - data: { - status: diff.status, - diffName: diff.diffName, - pixelMisMatchCount: diff.pixelMisMatchCount, - diffPercent: diff.diffPercent, - }, + it('with results', async () => { + const diff: DiffResult = { + status: TestStatus.unresolved, + diffName: 'diff image name', + pixelMisMatchCount: 11, + diffPercent: 22, + isSameDimension: true, + }; + const id = 'some id'; + const testRunUpdateMock = jest.fn(); + service = await initService({ + testRunUpdateMock, + }); + + await service.saveDiffResult(id, diff); + + expect(testRunUpdateMock).toHaveBeenCalledWith({ + where: { id }, + data: { + status: diff.status, + diffName: diff.diffName, + pixelMisMatchCount: diff.pixelMisMatchCount, + diffPercent: diff.diffPercent, + }, + }); }); }); diff --git a/src/test-runs/test-runs.service.ts b/src/test-runs/test-runs.service.ts index 3eccd8d5..69eec896 100644 --- a/src/test-runs/test-runs.service.ts +++ b/src/test-runs/test-runs.service.ts @@ -146,7 +146,9 @@ export class TestRunsService { await this.staticService.deleteImage(testRun.diffName); const diffResult = this.getDiff(baseline, image, testRun.diffTollerancePercent, testRun.ignoreAreas); - return this.saveDiffResult(id, diffResult); + const updatedTestRun = await this.saveDiffResult(id, diffResult); + this.emitUpdateBuildEvent(testRun.buildId); + return updatedTestRun; } async create(testVariation: TestVariation, createTestRequestDto: CreateTestRequestDto): Promise {