Remove overflow hidden, use width instead VC-983 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note for github. this should fix #269 |
nikitahl
reviewed
Jan 29, 2020
| element.parentElement.style.overflowX = 'hidden' | ||
| if (element) { | ||
| const currentStyleWidth = element.style.width; | ||
| const realWidth = element.getBoundingClientRect(); |
There was a problem hiding this comment.
Maybe it's worth define realWidth variable already with the width property? That would make more sense.
Otherwise looks strange on the next line realWidth.width.
nikitahl
reviewed
Jan 29, 2020
| if (element) { | ||
| const currentStyleWidth = element.style.width; | ||
| const realWidth = element.getBoundingClientRect(); | ||
| element.style.width = (realWidth.width - 1) + 'px'; |
There was a problem hiding this comment.
Maybe worth adding an explanatory comment why we subtract 1 from the realWidth.
There was a problem hiding this comment.
// Firefox horizontal scroll fix for left and right animations
there is already comment above
nikitahl
approved these changes
Jan 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.