Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix compile error under macos #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JaySon-Huang
Copy link

Fix the following errors:

  • Fix the cmake error under macos in the previous code
>  cmake -S . -B cmake-build
-- The C compiler identification is AppleClang 15.0.0.15000100
-- The CXX compiler identification is AppleClang 15.0.0.15000100
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
find package: SDL2 ...
cmake find SDL2 failed! use pkg-config...
pkg-config found OK
pkg-config found SDL2
SDL2 information:
        include dir: /opt/homebrew/include;/opt/homebrew/include/SDL2
        SDL libs: SDL2
CMake Error at 3rdlibs/sdl2/CMakeLists.txt:34 (target_include_directories):
  target_include_directories called with invalid arguments
  • std::filesystem::path does not have default hash operator to be the key of unordered_map. I've define a functor class for it
  • Fix that Sampler::Wrapper::operator== compare float array in an incorrect way

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Author

It can build successfully under my macbook now

>  cmake --build cmake-build
[  1%] Built target glad
[  4%] Built target imgui
[  7%] Built target ImGuizmo
[  7%] Built target stb_image
[  8%] Built target toml++
[ 13%] Built target mirrow
[ 14%] Built target miniaudio
[ 14%] Built target nanobench
[ 31%] Built target freetype
[ 43%] Built target lunasvg
[ 54%] Built target efsw
[ 64%] Built target efsw-static
[ 70%] Built target easy_profiler
[ 71%] Built target profiler_converter
[ 72%] Built target profiler_sample
[ 73%] Built target profiler_sample_disabled_profiler
[ 74%] Built target profiler_reader
[ 75%] Built target nickel_core
[ 87%] Built target nickel
[ 87%] Built target ImGuiPlugin
[ 94%] Built target editor
[ 94%] Built target gjk_bench
[ 95%] Built target geom
[ 96%] Built target cgmath
[ 97%] Built target tweeny
[ 97%] Built target csv_iterator
[ 98%] Built target gjk
[ 99%] Built target geom_testbed
[100%] Built target physics_testbed

Signed-off-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant