New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host/config: LOG_IMPORTS, LOG_EXPORTS, LOG_ACTIVE_SHADERS, LOG_UNIFORMS converted to Config settings #339

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@bsinky
Copy link
Contributor

bsinky commented Oct 7, 2018

Changes two of the constants mentioned in #324. I wanted to get some feedback before getting further into the codebase to tackle the other areas mentioned in that issue. Since I'm not a C++ dev, things may be a little rocky at first.

I appreciate any possible constructive criticism, thanks!

@VelocityRa
Copy link
Member

VelocityRa left a comment

LGTM, you can do the rest this way as well. 👍
In the future we might want to make the config a global for convenience, but for now let's try and see if it's not too annoying to pass it around everywhere like that.

@bsinky bsinky changed the title host/config: LOG_IMPORTS and LOG_EXPORTS converted to Config settings host/config: LOG_IMPORTS, LOG_EXPORTS, LOG_ACTIVE_SHADERS, LOG_UNIFORMS converted to Config settings Oct 8, 2018

Show resolved Hide resolved src/emulator/renderer/include/renderer/functions.h
Show resolved Hide resolved src/emulator/host/src/config.cpp Outdated
Show resolved Hide resolved src/emulator/host/src/config.cpp Outdated

@VelocityRa VelocityRa merged commit 17c238b into Vita3K:master Oct 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bsinky bsinky deleted the bsinky:add-more-cli-options branch Oct 11, 2018

pent0 added a commit to pent0/Vita3K that referenced this pull request Oct 15, 2018

host/config: LOG_* switches converted to Config settings (Vita3K#339)
* host/config: LOG_IMPORTS and LOG_EXPORTS converted to Config settings

* host/config: LOG_ACTIVE_SHADERS converted to Config setting

* host/config: LOG_UNIFORMS converted to Config setting

* host/config: fix indentation

VelocityRa added a commit to VelocityRa/Vita3K that referenced this pull request Jan 1, 2019

host/config: LOG_* switches converted to Config settings (Vita3K#339)
* host/config: LOG_IMPORTS and LOG_EXPORTS converted to Config settings

* host/config: LOG_ACTIVE_SHADERS converted to Config setting

* host/config: LOG_UNIFORMS converted to Config setting

* host/config: fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment