New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host/config: Log config settings during init #344

Merged
merged 2 commits into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@bsinky
Copy link
Contributor

bsinky commented Oct 13, 2018

Addresses #342 by logging all current config settings during config::init.

Not sure if there's a better way to work with the lle_modules vector, I may have missed an existing utility somewhere to combine them into a comma-separated string.

Also not totally sure if INFO is the right logging level, I could see DEBUG being a good fit as well.

Thanks in advance for the review!

Sample log:

[20:30:46.738] |I| [config::init]:  input-installed-id: CRFT00001
[20:30:46.740] |I| [config::init]:  lle-modules: test,test,test,test
[20:30:46.741] |I| [config::init]:  log-level: 2
[20:30:46.741] |I| [config::init]:  log-imports: true
[20:30:46.742] |I| [config::init]:  log-exports: true
[20:30:46.742] |I| [config::init]:  log-active-shaders: true
[20:30:46.742] |I| [config::init]:  log-uniforms: false
@VelocityRa
Copy link
Member

VelocityRa left a comment

Thanks, just a small nit

Show resolved Hide resolved src/emulator/host/src/config.cpp Outdated

@VelocityRa VelocityRa merged commit ebee18e into Vita3K:master Oct 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bsinky bsinky deleted the bsinky:log-config-values branch Oct 13, 2018

VelocityRa added a commit to VelocityRa/Vita3K that referenced this pull request Jan 1, 2019

host/config: Log config settings during init (Vita3K#344)
* host/config: Log config settings during init

* host/config: fix variable declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment