Skip to content

chore(spectronaut): Remove unnecessary columns from spectronaut example for vignette clarity#139

Merged
tonywu1999 merged 1 commit into
develfrom
delete-columns
Jun 5, 2026
Merged

chore(spectronaut): Remove unnecessary columns from spectronaut example for vignette clarity#139
tonywu1999 merged 1 commit into
develfrom
delete-columns

Conversation

@tonywu1999

@tonywu1999 tonywu1999 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

Users can remove and add columns to a Spectronaut dataset, so showing a Spectronaut dataset with more columns than needed is unnecessary and causes confusion.

Changes

  • Remove all unnecessary columns that MSstats doesn't process with the Spectronaut converter for the MSstats+ spectronaut report.

Testing

  • Verified existing tests pass and MSstats+ vignette doesn't break.
  • Current unit tests pass

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • inst/tinytest/raw_data/Spectronaut/spectronaut_quality_input.csv is excluded by !**/*.csv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 05da8266-756a-4efe-9559-b2fd45e04bf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch delete-columns

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tonywu1999 tonywu1999 merged commit 9f0fee9 into devel Jun 5, 2026
2 checks passed
@tonywu1999 tonywu1999 deleted the delete-columns branch June 5, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant