Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly aggressive caching of "Unavailable" thumbnails #472

Closed
romanrm opened this issue Feb 12, 2019 · 5 comments
Closed

Overly aggressive caching of "Unavailable" thumbnails #472

romanrm opened this issue Feb 12, 2019 · 5 comments

Comments

@romanrm
Copy link

@romanrm romanrm commented Feb 12, 2019

Sometimes I upload reprints of songs which went unavailable on their original source: https://vocadb.net/L/6823
Currently 9 out of 58 songs continue to show the generic "Video unavailable" thumbnail in songlists and the like, despite the YouTube media marked as unavailable in the song, and an alternative existing (and many months passed).
Media with the "Unavailable" checkbox should not be considered as thumbnail source and thumbnails should be (re)fetched from the still available media, if any.
Thanks!

@riipah

This comment has been minimized.

Copy link
Member

@riipah riipah commented Feb 12, 2019

Currently unavailable PVs are also included in search for thumbnails. That can be changed.

riipah added a commit that referenced this issue Feb 24, 2019
riipah added a commit that referenced this issue Feb 24, 2019
@riipah

This comment has been minimized.

Copy link
Member

@riipah riipah commented Feb 24, 2019

These songs had also another problem. They only have "Other" PVs that are still active, and "Other" PVs were not considered, unless they're the only PVs available. Well, I changed that too.

@riipah riipah closed this Feb 24, 2019
@riipah riipah reopened this Feb 25, 2019
@riipah

This comment has been minimized.

Copy link
Member

@riipah riipah commented Feb 25, 2019

I just realized there is still a problem with this change. Private PVs are marked as unavailable here, but the thumbnail is usually still available. For Nico Nico, thumbnail might be available even after deletion. So we do need to consider disabled PVs too. Perhaps it's ok to check active PVs first, then disabled.

Currently the order is

  • Active original
  • Active reprint
  • Active other
  • Any original
  • Any PV
riipah added a commit that referenced this issue Feb 25, 2019
@riipah riipah closed this Feb 27, 2019
@romanrm

This comment has been minimized.

Copy link
Author

@romanrm romanrm commented Mar 4, 2019

Has this been deployed to the site? Or maybe it doesn't solve the issue entirely?
At https://vocadb.net/L/6823 on page 3 a few still show broken icons.
Or even some popular stuff such as https://vocadb.net/L/8140

@riipah

This comment has been minimized.

Copy link
Member

@riipah riipah commented Mar 4, 2019

The thumbnails need to be updated per song. That means removing a PV and then re-adding it. There's also a mod maintenance action for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.