Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gratnite 6.0.0 removed About dialogs #483

Closed
2 tasks done
Foxboron opened this issue Apr 1, 2021 · 1 comment
Closed
2 tasks done

Gratnite 6.0.0 removed About dialogs #483

Foxboron opened this issue Apr 1, 2021 · 1 comment

Comments

@Foxboron
Copy link

Foxboron commented Apr 1, 2021

Prerequisites

  • I have searched the Issues list for open and closed issues and believe this is a unique, currently unreported bug.

Describe the bug

vocal fails to build with granite 6.0.0 because About dialogs have been removed.

elementary/granite#450

To Reproduce

Steps to reproduce the behavior:
Build vocal towards granite 6.0.0

Expected behavior

It should build.

Logs

[  4%] Generating data/com.github.needleandthread.vocal.gresource.c
/build/vocal/src/vocal-2.4.2/src/MainWindow.vala:419.17-419.41: error: The name `show_about' does not exist in the context of `Vocal.VocalApp'
                controller.app.show_about (this);
                ^^^^^^^^^^^^^^^^^^^^^^^^^
Command-line option `--thread` is deprecated and will be ignored
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [CMakeFiles/com.github.needleandthread.vocal.dir/build.make:231: com.github.needleandthread.vocal_valac.stamp] Error 1
make[1]: *** [CMakeFiles/Makefile2:127: CMakeFiles/com.github.needleandthread.vocal.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  4%] Built target i18n
make: *** [Makefile:136: all] Error 2

Platform Information

Please share as many of the following details as possible:

  • Linux distrubution: Arch Linux
  • OS version: current
  • Desktop environment: N/A

Please check the applicable option below:

  • I'm using a different version (please note here) : 2.4.2

Additional context

We have just removed the About dialog from the Arch package until there is an upstream fix.

archlinux/svntogit-community@03543ff#diff-3e341d2d9c67be01819b25b25d5e53ea3cdf3a38d28846cda85a195eb9b7203a

@nathandyer
Copy link
Member

This has been fixed with our port to GTK4 and libadwaita (Granite has been dropped as a dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants