forked from tangrs/libnspire
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshots #1
Comments
Yep:
libnspire/src/services/screenshot.c Line 93 in 8df6f37
|
Looking at the TILP code, for RGB565 the RLE works in 32-bit blocks instead of 8-bit ones, which it doesn't implement. This is missing on https://hackspire.org/index.php?title=USB_Protocol#Screenshot_.28RLE.29 as well. |
Vogtinator
added a commit
that referenced
this issue
Nov 26, 2022
- Fix typo: bbp -> bpp - Make the transfer work with big packets - Fix rle_decode for other bpp values: work in units of 2px
Implemented now with 7d7d962, tested with my CX II. |
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to figure out how to decode screenshots. On my CX running 4.5.0, TiLP takes this screenshot:


However, when trying to decode with this library, I get:
As there's black on the bottom, this isn't a swapping-width-and-length issue, nor is it a color conversion error (or if it is, it's not the main issue) as then there would be patterns of identical colors. My guess is that it's a RLE decoding error, as here's what TiLP does:
versus this library:
This library doesn't switch between calculator variants and is considerably shorter, so I'd then assume that this library is implemented incorrectly.
The text was updated successfully, but these errors were encountered: