ENG-10737: Fix for EE crash in full join query #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * which were not, so as to provide null-padded rows. | ||
| * | ||
| * The physical tuple address in the real table and the corresponding | ||
| * tuple index in the TableTupleFilter are related by the following |
There was a problem hiding this comment.
An Ascii Art picture would really help here.
|
Makes sense to me. I just had the one spelling correction. |
Per Bill's feedback
|
Thanks Bill. I wasn't sure if you were serious about the ASCII art. I added some more clarifying comments though. |
yzhang1991
pushed a commit
that referenced
this pull request
Jul 27, 2016
* ENG-10737 Corrected tuple index to address calculation * Corrected logic to recover tuple address from the tabletuplefilter index * Make sure the table has more than one block * Fix test in memcheck mode * Add some comments to clarify things that confused me * Fix type and add more comments Per Bill's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is from Mike A. His change was to update some of the logic in
TableTupleFilterand to add a unit test that covers his change.I found that the unit test didn't pass in memcheck mode, so fixed it. I also added some comments to the class
TableTupleFilter.