Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option round shape. Just proposing square to round shape... #60

Closed
wants to merge 1 commit into from
Closed

add option round shape. Just proposing square to round shape... #60

wants to merge 1 commit into from

Conversation

nicolasfourcade
Copy link

@nicolasfourcade nicolasfourcade commented May 24, 2017 •
edited
Loading

add option round shape. Just changing square to round...

@tomer-amir-vonage
Copy link
Contributor

Hi and thanks for contributing to this plugin!
I'd like to review it, but it seems to me like your branch is not up to date with our latest version which makes it hard for me to check it.

Please merge all changes from the master branch and push them, and I'll take a look again at your changes

@YehonatanVonage
Copy link
Contributor

YehonatanVonage commented Dec 5, 2017 •
edited
Loading

Hi @nicolasfourcade,
Your code is obsolete, and doesn't do what it supposed to.
Nevertheless, I created an option to change the panel corner radius in the master branch, and this option will be available in the next Grafana Status Panel version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasfourcade @tomer-amir-vonage @YehonatanVonage @nicolas-fourcade-penbase