Improve message display

[Marc-Assmann]

Currently the metric values are only displayed in case "Show Always" is checked.
This causes all messages to be displayed even when there is no warning.

This pull request replaces the checkbox with a drop down for a finer grained configuration on when to display a metric value next along with the alias:

• Never - The value will never be displayed, only the alias in warning or critical state
• When Critical - The alias + the value will be displayed in critical state only
• When Warning - The alias + the value will be displayed in warning or critical state
• Always - The alias + the value will always be displayed, regardless critical and warning state

In order to keep the current behaviour, the default setting is "Never".
When upgrading from a previous version, "Show Always" is converted to "Always".

On the UI, "Display Type" is renamed to "Display Position" to make that setting better understandable in its context.

[tomer-amir-vonage]

Hi Marc,

thanks for contributing!
sounds like a good addition to this plugin. We have a bit of a backlog in pull requests, so I'll review it once we're done with the previous PRs, but for now, there is a small issue that I'm not sure I like,

When you call the default behavior 'Never' it sounds like the measurement will never be displayed.
It's good that you added a tooltip that explains the behavior, but could you try to find a better name?

Thanks!

[YehonatanVonage]

Hi @Marc-Assmann,
Thanks for the contribution. I merged your code to a side branch, so I can add some more fixes and features relevant to your commit.

Your changes will be available in the next version.

[Marc-Assmann]

Hi @YehonatanVonage,
Thank's a lot for picking this up!
In the meanwhile I have tried to rebase the pull request but didn't know on how to improve the wording as requested by TomerAmirV above.
But I see you now solved it by adding finer grained control on the display of the alias as well which looks very good!
Best regards,
Marc